Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the kubeadm registry was backported #15546

Closed

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Dec 23, 2022

To kubernetes versions: 1.22.18, 1.23.15, 1.24.9

Versions -1.21 use old, versions 1.25+ use new.

Follow up to:

Reference:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2022
@afbjorklund afbjorklund requested review from spowelljr and removed request for prezha December 23, 2022 10:04
To kubernetes versions: 1.22.18, 1.23.15, 1.24.9

Versions -1.21 use old, versions 1.26+ use new.
@afbjorklund
Copy link
Collaborator Author

If we override the default value and retag the preload after loading, we can change even the existing releases.

--image-repository=registry.k8s.io

docker tag k8s.gcr.io/pause:3.2 registry.k8s.io/pause:3.2

But it will go in a separate PR, since it is a separate feature. Changing the current releases is a good start...

@afbjorklund
Copy link
Collaborator Author

The binaries were changed here, to use dl.k8s.io:

@medyagh
Copy link
Member

medyagh commented Feb 13, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 13, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15546) |
+-------------------+----------+---------------------+
| minikube start    | 53.1s    | 51.8s               |
| ⚠️  enable ingress | 25.2s    | 36.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 53.6s 55.6s 53.4s 52.6s 50.6s
Times for minikube (PR 15546) start: 56.0s 51.4s 48.7s 48.7s 54.0s

Times for minikube ingress: 24.2s 28.2s 24.7s 24.7s 24.2s
Times for minikube (PR 15546) ingress: 24.7s 25.1s 84.7s 24.2s 25.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15546) |
+-------------------+----------+---------------------+
| minikube start    | 26.2s    | 26.0s               |
| ⚠️  enable ingress | 22.2s    | 32.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 19.5s 21.0s 29.1s 21.1s 20.1s
Times for minikube (PR 15546) ingress: 19.0s 21.1s 19.6s 50.5s 50.6s

Times for minikube (PR 15546) start: 26.0s 27.2s 25.2s 25.1s 26.4s
Times for minikube start: 25.7s 25.6s 27.3s 26.8s 25.8s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15546) |
+-------------------+----------+---------------------+
| minikube start    | 22.2s    | 21.6s               |
| ⚠️  enable ingress | 29.4s    | 45.0s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 21.7s 22.9s 22.3s 22.2s 21.7s
Times for minikube (PR 15546) start: 21.1s 21.6s 21.1s 21.9s 22.0s

Times for minikube ingress: 19.5s 31.5s 32.6s 31.5s 31.6s
Times for minikube (PR 15546) ingress: 81.0s 31.6s 33.1s 31.5s 47.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/parallel/ConfigCmd (gopogh) 15.03 (chart)
Hyper-V_Windows TestAddons/parallel/CloudSpanner (gopogh) 37.11 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.15 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Mar 29, 2023

@afbjorklund I believe this PR been replaced by #16029 and we could safely close this one, if you agree

@spowelljr
Copy link
Member

Due to #16017 we're always going to be using the new registry so this PR is no longer needed. Superseded by #16029

@spowelljr spowelljr closed this Mar 29, 2023
@afbjorklund
Copy link
Collaborator Author

It was mostly if you wanted a more fine-grained report on when kubeadm default was bumped ?

But it should be safe to supply the kubernetes registry as a parameter, even when it is the default...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants