-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the kubeadm registry was backported #15546
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fdbc9e2
to
871a6be
Compare
To kubernetes versions: 1.22.18, 1.23.15, 1.24.9 Versions -1.21 use old, versions 1.26+ use new.
871a6be
to
1999305
Compare
If we override the default value and retag the preload after loading, we can change even the existing releases.
But it will go in a separate PR, since it is a separate feature. Changing the current releases is a good start... |
The binaries were changed here, to use |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 53.6s 55.6s 53.4s 52.6s 50.6s Times for minikube ingress: 24.2s 28.2s 24.7s 24.7s 24.2s docker driver with docker runtime
Times for minikube ingress: 19.5s 21.0s 29.1s 21.1s 20.1s Times for minikube (PR 15546) start: 26.0s 27.2s 25.2s 25.1s 26.4s docker driver with containerd runtime
Times for minikube start: 21.7s 22.9s 22.3s 22.2s 21.7s Times for minikube ingress: 19.5s 31.5s 32.6s 31.5s 31.6s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
@afbjorklund I believe this PR been replaced by #16029 and we could safely close this one, if you agree |
It was mostly if you wanted a more fine-grained report on when But it should be safe to supply the kubernetes registry as a parameter, even when it is the default... |
To kubernetes versions: 1.22.18, 1.23.15, 1.24.9
Versions -1.21 use old, versions 1.25+ use new.
Follow up to:
Reference: