Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Headlamp version to 0.15.0 #15817

Closed

Conversation

joaquimrocha
Copy link
Contributor

Upgrade Headlamp version to 0.15.0
cc: @yolossn

Signed-off-by: yolossn <yolossn@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15817) |
+----------------+----------+---------------------+
| minikube start | 53.3s    | 53.3s               |
| enable ingress | 26.1s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube start: 51.8s 51.8s 55.7s 53.9s 53.3s
Times for minikube (PR 15817) start: 53.5s 53.9s 52.6s 53.1s 53.2s

Times for minikube ingress: 29.3s 25.3s 24.1s 25.3s 26.8s
Times for minikube (PR 15817) ingress: 24.8s 29.3s 26.8s 25.8s 25.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15817) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 26.9s               |
| enable ingress | 39.2s    | 21.7s               |
+----------------+----------+---------------------+

Times for minikube start: 26.8s 26.8s 26.8s 27.2s 25.9s
Times for minikube (PR 15817) start: 26.6s 26.8s 27.7s 26.8s 26.7s

Times for minikube ingress: 23.1s 21.1s 81.6s 50.1s 20.1s
Times for minikube (PR 15817) ingress: 20.6s 20.1s 21.6s 25.1s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15817) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.2s               |
| enable ingress | 34.8s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 23.3s 22.1s 22.2s 22.4s
Times for minikube (PR 15817) start: 22.7s 22.4s 22.4s 22.6s 21.2s

Times for minikube ingress: 31.6s 21.6s 47.7s 47.6s 25.6s
Times for minikube (PR 15817) ingress: 31.6s 32.6s 32.6s 31.6s 32.6s

@joaquimrocha
Copy link
Contributor Author

We've had some issues related to having migrated the org where we had headlamp (from kinvolk to headlamp-k8s).
It should be good to test now. Sorry for the inconvenience.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is not able to be pulled

Warning  Failed     6m31s (x4 over 8m)      kubelet            Failed to pull image "ghcr.io/headlamp-k8s/headlamp:v0.15.0@sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": rpc error: code = Unknown desc = Error response from daemon: Get "https://ghcr.io/v2/headlamp-k8s/headlamp/manifests/sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": unauthorized

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joaquimrocha
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joaquimrocha
Copy link
Contributor Author

The image is not able to be pulled

Warning  Failed     6m31s (x4 over 8m)      kubelet            Failed to pull image "ghcr.io/headlamp-k8s/headlamp:v0.15.0@sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": rpc error: code = Unknown desc = Error response from daemon: Get "https://ghcr.io/v2/headlamp-k8s/headlamp/manifests/sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": unauthorized

I think it should be available now. Maybe there was a longer delay than I expected in getting the new package repo public (it was not public just by default...).

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joaquimrocha, I am able to confirm that the image is now publicly available to pull. However, I did a scan on the new image and it includes a high rated CVE which is not present in the previous image.

Your old image uses alpine:3.15.6 while the new image uses alpine:3.17.0 which has openssl/libcrypto3@3.0.7 which includes CVE-2022-3996. Therefore I'd rather stick with the current image until that vulnerability is patched.

@joaquimrocha
Copy link
Contributor Author

Your old image uses alpine:3.15.6 while the new image uses alpine:3.17.0 which has openssl/libcrypto3@3.0.7 which includes CVE-2022-3996. Therefore I'd rather stick with the current image until that vulnerability is patched.

Ouch! Thanks for spotting this @spowelljr . I agree with stalling.
That reminds me we should have some scans in place ourselves for that.

We will update the PR once we have an image without the CVE.

@joaquimrocha
Copy link
Contributor Author

Closing since we have a new bug fix version coming (0.15.1 already released, PR coming soon).

@joaquimrocha joaquimrocha deleted the update_headlamp_0.15.0 branch February 16, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants