-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Headlamp version to 0.15.0 #15817
Conversation
Signed-off-by: yolossn <yolossn@users.noreply.github.com>
Hi @joaquimrocha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 51.8s 51.8s 55.7s 53.9s 53.3s Times for minikube ingress: 29.3s 25.3s 24.1s 25.3s 26.8s docker driver with docker runtime
Times for minikube start: 26.8s 26.8s 26.8s 27.2s 25.9s Times for minikube ingress: 23.1s 21.1s 81.6s 50.1s 20.1s docker driver with containerd runtime
Times for minikube start: 22.0s 23.3s 22.1s 22.2s 22.4s Times for minikube ingress: 31.6s 21.6s 47.7s 47.6s 25.6s |
We've had some issues related to having migrated the org where we had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is not able to be pulled
Warning Failed 6m31s (x4 over 8m) kubelet Failed to pull image "ghcr.io/headlamp-k8s/headlamp:v0.15.0@sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": rpc error: code = Unknown desc = Error response from daemon: Get "https://ghcr.io/v2/headlamp-k8s/headlamp/manifests/sha256:a797a472cb8133e543b7bcacd255500ae37357d11fe5c99a2e54c3f882a3d9fc": unauthorized
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joaquimrocha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it should be available now. Maybe there was a longer delay than I expected in getting the new package repo public (it was not public just by default...). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joaquimrocha, I am able to confirm that the image is now publicly available to pull. However, I did a scan on the new image and it includes a high rated CVE which is not present in the previous image.
Your old image uses alpine:3.15.6
while the new image uses alpine:3.17.0
which has openssl/libcrypto3@3.0.7
which includes CVE-2022-3996. Therefore I'd rather stick with the current image until that vulnerability is patched.
Ouch! Thanks for spotting this @spowelljr . I agree with stalling. We will update the PR once we have an image without the CVE. |
Closing since we have a new bug fix version coming (0.15.1 already released, PR coming soon). |
Upgrade Headlamp version to 0.15.0
cc: @yolossn