Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Headlamp version to 0.15.1 #15876

Closed
wants to merge 1 commit into from

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Feb 17, 2023

No description provided.

Signed-off-by: yolossn <sannagaraj@microsoft.com>
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yolossn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yolossn
Once this PR has been reviewed and has the lgtm label, please assign afbjorklund for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

CLA needs to be signed

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 26, 2023

@yolossn
Copy link
Contributor Author

yolossn commented Feb 27, 2023

What is up with all the headlamp spam ?

Sorry for the inconvenience, We recently had our organization moved from kinvolk to headlamp-k8s and one of the Github Actions setup to automate the process of creating the Update PR picked up the wrong configurations. We have fixed it and will make sure it works properly going forward. The same has been mentioned here. Once again sorry for the spam.

@yolossn
Copy link
Contributor Author

yolossn commented Mar 6, 2023

@spowelljr I signed the CLA multiple times but the status is not updated. Is there something that I am missing?

@spowelljr
Copy link
Member

/check-cla

@spowelljr
Copy link
Member

spowelljr commented Mar 6, 2023

Your commit email is with sannagaraj@microsoft.com but your commit on #15869 is using nssvlr@gmail.com so I'm assuming you signed the CLA with the latter. If you could change the commit to use the email you signed the CLA with it should resolve.

@yolossn
Copy link
Contributor Author

yolossn commented Mar 7, 2023

Your commit email is with sannagaraj@microsoft.com but your commit on #15869 is using nssvlr@gmail.com so I'm assuming you signed the CLA with the latter. If you could change the commit to use the email you signed the CLA with it should resolve.

I signed the CLA with both the emails but still faced the same issue. I tried changing both the commits to use the same commit email sannagaraj@microsoft.com and still CLA fails on this one and passes on #15869.

@spowelljr
Copy link
Member

I'm not too sure, if you make another branch and commit with the microsoft email and then create a PR as a test I'd be curious if it passes or not. If it does maybe closing this PR and reopening could resolve it. If it doesn't then there seems there would be an issue with the microsoft email and the CLA check.

@yolossn
Copy link
Contributor Author

yolossn commented Mar 8, 2023

I'm not too sure, if you make another branch and commit with the microsoft email and then create a PR as a test I'd be curious if it passes or not. If it does maybe closing this PR and reopening could resolve it. If it doesn't then there seems there would be an issue with the microsoft email and the CLA check.

Thanks for the pointer, I created a new PR as you suggested and the CLA passed, so Ill close this PR and open a new one.

@yolossn yolossn closed this Mar 8, 2023
@yolossn
Copy link
Contributor Author

yolossn commented Mar 8, 2023

Opened a new PR for the same.

@joaquimrocha joaquimrocha deleted the update_headlamp_0.15.1 branch March 10, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants