Add a storage-provisioner-gluster addon #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this addon dynamic provisioning based on Gluster can be enabled:
$ minikube addons enable storage-provisioner-gluster
This will deploy several pods in a new 'storage-gluster' namespace:
- glusterfs, storage service with a 10GB sparse /srv/fake-disk.img
- heketi, a smart Gluster volume manager
- glusterfile-provisioner, external-storage provisioner
In addition, the StorageClass 'glusterfile' will be created. It is
currently not configured as default StorageClass, so PVCs need to refer
to the new StorageClass.
…-default There can only be one StorageClass be marked as default. When the storage-provisioner-gluster addon is enabled, users expect it to be the default StorageClass. Instead of removing the "is-default" annotation from the other StorageClasses, set it to "false". This leaves only the "glusterfile" StorageClass as "is-default".
When a storage provider is enabled (storage-provisioner-glusterfile), mark it "is-default" and set "is-default" to "false" in all other StorageClasses.
k8s-ci-robot
added
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
@minikube-bot OK to test |
tstromberg
added
the
lgtm
tstromberg
approved these changes
Jan 16, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon makes it easy for users to deploy Gluster with dynamic provisioning. A simple
is sufficient to get the required Pods and StorageClass.
The included
README.mdexplains a little more how things work and how users can use the PVCs that get dynamically created for the user.The 2nd and 3rd patches in this PR make the last enabled storage addon the default StorageClass. That means if
storage-provisioner-glusteris enabled as last, the existing StorageClasses will have theiris-defaultannotation set tofalse, and forstorage-provisioner-glusterit is set totrue. The same counts for other orders in enabling.