-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-remove kube-dns addon #3556
Re-remove kube-dns addon #3556
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robrich If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
I signed it |
Thank you for the patch! |
Glad to help. What's the release cadence? (This definitely doesn't deserve it's own release.) |
2091f8c
on 11/13/18 removed kube-dns addon3c3b736
on 8/8/18 added back in the reference in addons.go (accidentally?) but didn't add deploy/addons/kube-dns/* files referenced8bc8816
on 1/15/19 merged in PR #3521Now when running
minikube addons list
I see:and when I run
minikube addons enable kube-dns
I see:This PR attempts to re-remove
kube-dns
from the addons list.