-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: status-ng: support for transition states, errors, warnings #8813
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: 5f41e090-ccf8-11ea-a3f9-a5c55cea7642 |
Travis tests have failedHey @tstromberg, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: 66774270-cd24-11ea-a3f9-a5c55cea7642 |
Obsoleted by #8868 |
Fixes #8730
Don't expect this code to compile just yet, but here is the TL;DR:
minikube status
has been upgraded to communicate errors and transition statesOld Output
New Output
Old JSON
New JSON
libmachine/state
withminikube/state
--compat
flag, which will be initially set to true.