-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: Add experimental cluster JSON status with state transition support #8868
status: Add experimental cluster JSON status with state transition support #8868
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Travis tests have failedHey @tstromberg, 1st Buildmake test
2nd Buildmake test
TravisBuddy Request Identifier: 124acd10-d112-11ea-b8d2-e37d5f97d09d |
kvm2 Driver |
/ok-to-test |
Travis tests have failedHey @tstromberg, 1st Buildmake test
2nd Buildmake test
TravisBuddy Request Identifier: 209dc3b0-d115-11ea-b8d2-e37d5f97d09d |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 40829700-d115-11ea-b8d2-e37d5f97d09d |
kvm2 Driver Times for Minikube (PR 8868): [63.09456805600001 64.910569062 63.339984964] Averages Time Per Log
docker Driver Times for Minikube (PR 8868): [26.915811311000006 27.28603208 25.966488966] Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with nits
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: f49d8410-d1de-11ea-bb2f-e1a2ee6530fc |
kvm2 Driver Times for Minikube (PR 8868): [67.525950823 61.612314134 61.22690773699999] Averages Time Per Log
docker Driver Times for Minikube (PR 8868): [26.122615714 25.347114805 24.899249598] Averages Time Per Log
|
/ok-to-test |
Travis tests have failedHey @tstromberg, 1st Buildmake test
TravisBuddy Request Identifier: 975e98a0-d1e0-11ea-bb2f-e1a2ee6530fc |
kvm2 Driver Times for Minikube (PR 8868): [64.071216339 63.20287118900001 63.43389517699999] Averages Time Per Log
docker Driver Times for Minikube (PR 8868): [26.827779532000005 27.324959196000002 26.955427038999996] Averages Time Per Log
|
This implements state transitions on top of the recent CloudEvents JSON output work. Fixes #8730
In a nutshell:
--layout=cluster
, which supports a status fields along with the current step:$MINIKUBE_HOME/<profile>/events.json
--layout=cluster
is invoked.