Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machine readable description of platforms #1836

Closed
hasheddan opened this issue Jan 11, 2021 · 21 comments
Closed

Add machine readable description of platforms #1836

hasheddan opened this issue Jan 11, 2021 · 21 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@hasheddan
Copy link
Contributor

hasheddan commented Jan 11, 2021

What would you like to be added:

A machine-readable file describing the platforms (OS / architecture) that each binary is expected to be released for (xref kubernetes/sig-release#1360).

Why is this needed:

This description will allow krel to perform checks on produced artifacts and make sure that the artifacts that are intended to be released actually are being released.

/assign

@hasheddan hasheddan added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 11, 2021
@hasheddan
Copy link
Contributor Author

@justaugustus @saschagrunert thinking about this a little more, I wonder if it may make sense for this to live in k/k. Krel theoretically should be able to run a release for any project, so it seems the project itself should indicate the artifacts that it intends to be released. This could be a standard that we define for "krel-releasable" projects, in which case maybe we add that standard in this repo and then add an implementation in k/k. Thoughts?

@hasheddan
Copy link
Contributor Author

@dims in case you have any thoughts on this as well :)

@hasheddan
Copy link
Contributor Author

This could also be related to #1819 if we want to have a formal specification.

@dims
Copy link
Member

dims commented Jan 11, 2021

@hasheddan it would make sense to reach out to @swinslow from LF to have a chat as it looks like there is scanning to SPDX that's being done:
https://github.com/lfscanning/spdx-cncf/tree/master/kubernetes/2020-02

Also related:
cncf/foundation#6

The license exceptions granted by CNCF for non-standard licenses are also in SPDX:
https://github.com/cncf/foundation/blob/master/license-exceptions/README.md

@hasheddan
Copy link
Contributor Author

Thanks @dims! This looks pretty important in regards to the BOM effort, but I am not sure it directly relates the list of supported platforms that we intend to release

@saschagrunert
Copy link
Member

saschagrunert commented Jan 11, 2021

Krel theoretically should be able to run a release for any project,

krel stage/release is tightly scoped to Kubernetes, so it seems fine to me to stick to k/release. I can imagine that we have an API for checking binaries of different formats (like elf) against a set of criterias (like ABI or ISA). This could be re-used by other projects, too.

@dims
Copy link
Member

dims commented Jan 11, 2021

whoops! sorry my head was still in the BOM :) @hasheddan

@hasheddan
Copy link
Contributor Author

krel stage/release is tightly scoped to Kubernetes, so it seems fine to me to stick to k/release.

@saschagrunert this is definitely true today, but some of the original discussion when krel was started was around moving towards more generally applicable tooling, which I think could influence this decision if we still have that goal.

@saschagrunert
Copy link
Member

@hasheddan I see your point. From a usability perspective, would it be better if the definitions live in k/k? Let's say we add/remove a binary, then it probably would make more sense for developers to modify the definition in k/k.

On the other hand: Let's assume that SIG Release owns the definitions. It's easier for us to change it in k/release rather than modifying k/k which might lead into a release blocker.

@hasheddan
Copy link
Contributor Author

@saschagrunert @justaugustus I am leaning towards something like a .krel.yml file in repos that krel releases. I think we should add an API in the form of Go structs in k/release that defines the schema for declaring binaries / images that should be produced. We could start with a kubernetes.krel.yml in k/release and test this out for a while before moving it to k/k, how does that sound?

@justaugustus justaugustus added this to the v1.21 milestone Jan 25, 2021
@saschagrunert
Copy link
Member

how does that sound?

Sounds good to me! 👍

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 25, 2021
@puerco
Copy link
Member

puerco commented May 25, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 25, 2021
@justaugustus justaugustus assigned puerco and cpanato and unassigned hasheddan Jun 22, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 20, 2021
@palnabarun
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 14, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants