Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Catalog: Ignore deprecated license IDs #2159

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 10, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This commit changes the license package to avoid using any
deprecated SPDX IDs from the SPDX catalog when training the
classifier. When scanning a file with those licenses, we will
now use the new labels exclusively.

Signed-off-by: Adolfo Garcia Veytia (puerco) adolfo.garcia@uservers.net

Which issue(s) this PR fixes:

Part of #1837

Special notes for your reviewer:

Minor cleanup

Does this PR introduce a user-facing change?

When training the license classifier, the `license` package will now ignore deprecated license IDs from the SPDX catalog.

This commit changes the license package to avoid using any
deprectated SPDX IDs from the SPDX catalog when training the
classifier. When scanning a file with those licenses, we will
now use the new labels exclusively.

Signed-off-by: Adolfo Garcia Veytia (puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 10, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2021
@puerco puerco added this to the v1.22 milestone Jul 10, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit add4fd8 into kubernetes:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants