Node testgrid dashboard cleanup #23231

ehashman · 2021-08-12T19:18:38Z

What should be cleaned up or changed:

As discussed in the SIG Node CI Subproject meeting today and last week, our testgrid dashboards are a bit of a mess:

Here is our cleanup plan:

Move all pr-* jobs across various tabs into a new sig-node-presubmits tab
Consider consolidating redundant tabs (e.g. sig-node-containerd and sig-node-containerd-io)
Remove double listed jobs to ensure they are filed in the right place (e.g. release-blocking jobs are already in sig-node-release-blocking and don't also need to be included under sig-node-kubelet)

Provide any links for context:

https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-features-master

/cc @adisky @matthyx @ipochi
/sig node

The text was updated successfully, but these errors were encountered:

matthyx · 2021-08-13T05:04:51Z

/assign
/assign @adisky

matthyx · 2021-08-13T08:31:11Z

Here is the list of all tabs (sorted):

dashboard_groups:
- name: sig-node
  dashboard_names:
    - sig-node-cadvisor
    - sig-node-containerd
    - sig-node-containerd-io # jobs in containerd/containerd repository
    - sig-node-cos
    - sig-node-cri
    - sig-node-cri-o
    - sig-node-cri-tools
    - sig-node-critical # This dashboard contains jobs that sig-node has deemed critical to the greater operation of the sig. They should always be green.
    - sig-node-kubelet
    - sig-node-node-feature-discovery
    - sig-node-node-problem-detector
    - sig-node-ppc64le
    - sig-node-presubmits
    - sig-node-release-blocking # This is a replica of sig-node jobs that are release blocking.
    - sig-node-security-profiles-operator

Not sure which ones could be merged...

adisky · 2021-08-16T10:42:56Z

sig-node-critical has only one job containerd node conformance https://github.com/kubernetes/test-infra/blob/master/config/testgrids/kubernetes/sig-node/config.yaml#L22, is this critical tab needed now considering we have containerd mandatory presubmit job?

adisky · 2021-08-16T10:57:55Z

Also should we also think about removing windows jobs from sig-node-containerd tab?
https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-windows/windows-gce.yaml#L405

matthyx · 2021-08-16T14:19:47Z

Agree with both... @ehashman wdyt?

matthyx · 2021-08-18T07:13:06Z

/cc @SergeyKanzhelev

SergeyKanzhelev · 2021-08-18T07:30:07Z

the idea of critical tab was a stepping stone to promote to release blocking as far as I remember. It didin't work as was intended

I'd vote for removing windows from containerd. But let's ping @marosset on the PR

adisky · 2021-08-18T07:57:35Z

the idea of critical tab was a stepping stone to promote to release blocking as far as I remember. It didin't work as was intended

Thanks for letting us know about this!! for now lets keep it as it is.

I'd vote for removing windows from containerd. But let's ping @marosset on the PR

for windows, lets wait for @marosset feedback

marosset · 2021-08-18T17:23:22Z

I'm OK with removing the windows tabs from sig-node-containerd.
We have Windows + containerd tests running as part of the SIG-Windows release informing dashboard https://testgrid.k8s.io/sig-windows-signal.

Since these are GCE jobs I'd like either @pjh or @ibabou to ACK this too

ibabou · 2021-08-18T18:41:25Z

I'm okay with removing the windows tabs from there. ACK. Having those as part of sig-windows-gce & sig-windows-*-release is sufficient.

pjh · 2021-08-20T01:00:09Z

+1, removing those Windows jobs from sig-node-containerd SGTM.

adisky · 2021-08-20T05:23:53Z

Thanks for the inputs from windows team, Now we have two items that need PR

remove windows jobs from containerd dashboard https://testgrid.k8s.io/sig-node-containerd
e.g. remove containerd dashboard from here https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-windows/windows-gce.yaml#L405, This has to be done for other windows jobs in containerd dashboard as well
move double listed jobs to ensure they are filed in the right place (e.g. release-blocking jobs are already in sig-node-release-blocking and don't also need to be included under sig-node-kubelet)
here remove jobs present in release-blocking dashboard from other sig node dashboards

you can use this https://cs.k8s.io/?q=node-kubelet-master&i=nope&files=&excludeFiles=&repos=kubernetes/test-infra to search for jobs and dashboard.

Debanitrkl · 2021-08-20T07:01:33Z

I can work on with the PR regarding removing windows jobs from containerd dasboard

rayandas · 2021-08-20T07:08:57Z

Hey @adisky I can work on the second item (move double listed jobs to ensure they are filed in the right place).

adisky · 2021-08-20T07:36:35Z

@Debanitrkl @rayandas Thanks for taking this up
/assign @Debanitrkl @rayandas for the two items mentioned above

Debanitrkl · 2021-08-20T07:57:23Z

/assign

rayandas · 2021-08-20T08:13:55Z

/assign

matthyx · 2021-08-25T19:05:32Z

Not sure we're done yet...
/reopen

k8s-ci-robot · 2021-08-25T19:05:46Z

@matthyx: Reopened this issue.

In response to this:

Not sure we're done yet...
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rajalakshmi-Girish · 2021-11-23T06:22:34Z

Can someone please suggest the right place to have the unit-tests tab which is currently under sig-node-ppc64le? https://k8s-testgrid.appspot.com/sig-node-ppc64le#unit-tests

This test grid seems essential to track k8s unit test failures on ppc64le.
cc @ehashman @SergeyKanzhelev @matthyx

Rajalakshmi-Girish · 2021-11-23T06:34:27Z

Can someone please suggest the right place to have the unit-tests tab which is currently under sig-node-ppc64le? https://k8s-testgrid.appspot.com/sig-node-ppc64le#unit-tests

This test grid seems essential to track k8s unit test failures on ppc64le. cc @ehashman @SergeyKanzhelev @matthyx

@spiffxp @mkumatag

mkumatag · 2021-11-23T06:41:25Z

Can someone please suggest the right place to have the unit-tests tab which is currently under sig-node-ppc64le? https://k8s-testgrid.appspot.com/sig-node-ppc64le#unit-tests
This test grid seems essential to track k8s unit test failures on ppc64le. cc @ehashman @SergeyKanzhelev @matthyx

@spiffxp @mkumatag

not sure either, wondering if we can add to some of the periodic jobs run(don't really know where are they??), worst case - lets create a new group called ibm like other groups we have in the testgrid.

k8s-triage-robot · 2022-02-21T06:54:09Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ehashman · 2022-03-03T20:24:17Z

I have a couple more small PRs and then I think this is done.

#25497 #25496

ehashman · 2022-03-03T20:24:32Z

/remove-lifecycle stale

matthyx · 2022-06-01T17:30:47Z

both remaining PRs are merged
/close

k8s-ci-robot · 2022-06-01T17:31:04Z

@matthyx: Closing this issue.

In response to this:

both remaining PRs are merged
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ehashman added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 12, 2021

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 12, 2021

k8s-ci-robot assigned adisky and matthyx Aug 13, 2021

matthyx mentioned this issue Aug 13, 2021

move all node pr-* jobs into sig-node-presubmits #23239

Merged

This was referenced Aug 16, 2021

Remove sig-node-ppc64le testgrid tab #23249

Closed

Consolidate containerd testgrid tabs #23251

Merged

Rename sig-node-cri tab to sig-node-docker #23252

Merged

k8s-ci-robot assigned Debanitrkl Aug 20, 2021

k8s-ci-robot assigned rayandas Aug 20, 2021

Debanitrkl mentioned this issue Aug 23, 2021

Node testgrid dashboard cleanup #23333

Merged

rayandas mentioned this issue Aug 23, 2021

Remove double listed release-blocking jobs. #23339

Merged

k8s-ci-robot closed this as completed in #23333 Aug 25, 2021

k8s-ci-robot reopened this Aug 25, 2021

Rajalakshmi-Girish mentioned this issue Dec 14, 2021

Move ppc64le results to a separate ibm dashboard group #24672

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2022

k8s-ci-robot closed this as completed Jun 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node testgrid dashboard cleanup #23231

Node testgrid dashboard cleanup #23231

ehashman commented Aug 12, 2021 •

edited

Loading

matthyx commented Aug 13, 2021

matthyx commented Aug 13, 2021 •

edited

Loading

adisky commented Aug 16, 2021

adisky commented Aug 16, 2021

matthyx commented Aug 16, 2021

matthyx commented Aug 18, 2021

SergeyKanzhelev commented Aug 18, 2021

adisky commented Aug 18, 2021 •

edited

Loading

marosset commented Aug 18, 2021 •

edited

Loading

ibabou commented Aug 18, 2021

pjh commented Aug 20, 2021

adisky commented Aug 20, 2021 •

edited

Loading

Debanitrkl commented Aug 20, 2021

rayandas commented Aug 20, 2021

adisky commented Aug 20, 2021 •

edited

Loading

Debanitrkl commented Aug 20, 2021

rayandas commented Aug 20, 2021

matthyx commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

Rajalakshmi-Girish commented Nov 23, 2021

Rajalakshmi-Girish commented Nov 23, 2021

mkumatag commented Nov 23, 2021

k8s-triage-robot commented Feb 21, 2022

ehashman commented Mar 3, 2022

ehashman commented Mar 3, 2022

matthyx commented Jun 1, 2022

k8s-ci-robot commented Jun 1, 2022

Node testgrid dashboard cleanup #23231

Node testgrid dashboard cleanup #23231

Comments

ehashman commented Aug 12, 2021 • edited Loading

matthyx commented Aug 13, 2021

matthyx commented Aug 13, 2021 • edited Loading

adisky commented Aug 16, 2021

adisky commented Aug 16, 2021

matthyx commented Aug 16, 2021

matthyx commented Aug 18, 2021

SergeyKanzhelev commented Aug 18, 2021

adisky commented Aug 18, 2021 • edited Loading

marosset commented Aug 18, 2021 • edited Loading

ibabou commented Aug 18, 2021

pjh commented Aug 20, 2021

adisky commented Aug 20, 2021 • edited Loading

Debanitrkl commented Aug 20, 2021

rayandas commented Aug 20, 2021

adisky commented Aug 20, 2021 • edited Loading

Debanitrkl commented Aug 20, 2021

rayandas commented Aug 20, 2021

matthyx commented Aug 25, 2021

k8s-ci-robot commented Aug 25, 2021

Rajalakshmi-Girish commented Nov 23, 2021

Rajalakshmi-Girish commented Nov 23, 2021

mkumatag commented Nov 23, 2021

k8s-triage-robot commented Feb 21, 2022

ehashman commented Mar 3, 2022

ehashman commented Mar 3, 2022

matthyx commented Jun 1, 2022

k8s-ci-robot commented Jun 1, 2022

ehashman commented Aug 12, 2021 •

edited

Loading

matthyx commented Aug 13, 2021 •

edited

Loading

adisky commented Aug 18, 2021 •

edited

Loading

marosset commented Aug 18, 2021 •

edited

Loading

adisky commented Aug 20, 2021 •

edited

Loading

adisky commented Aug 20, 2021 •

edited

Loading