Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sig-node-ppc64le testgrid tab #23249

Closed
wants to merge 1 commit into from
Closed

Remove sig-node-ppc64le testgrid tab #23249

wants to merge 1 commit into from

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Aug 16, 2021

ppc64le-conformance is already in conformance tab
https://github.com/kubernetes/test-infra/blob/master/config/testgrids/conformance/conformance-all.yaml#L132
https://testgrid.k8s.io/conformance-ppc64le

not sure about ppc64le-unit but does it belongs to sig-node?

Related :#23231

Signed-off-by: Aditi Sharma adi.sky17@gmail.com

/sig node

cc @ehashman @SergeyKanzhelev @matthyx

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 16, 2021
adisky
adisky commented Aug 16, 2021
View reviewed changes
config/testgrids/conformance/conformance-all.yaml
@@ -322,8 +322,6 @@ test_groups:
days_of_results: 7
column_header:
- configuration_value: k8s-build-version
- name: ppc64le-unit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what is the right way here, to remove it or add the test group in the dashboard ppc64le above
https://github.com/kubernetes/test-infra/blob/master/config/testgrids/conformance/conformance-all.yaml#L132

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Removal of this test group altogether shall miss the k8s unit testing on ppc64le.
Must find the appropriate place to add this test group and create a corresponding dashboard.
@mkumatag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adisky please revert this change; we only want to remove the SIG Node dashboards. The job belongs to conformance and we should leave their dashboards alone.

@adisky
Copy link
Contributor Author

adisky commented Aug 17, 2021

/assign @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2021
@matthyx
Copy link
Contributor

matthyx commented Oct 21, 2021

@adisky I think this is the only remaining PR for the cleanup initiated in #23231 could you rebase and have @SergeyKanzhelev approve it?

@ehashman
Copy link
Member

@adisky please rebase

@adisky
Remove sig-node-ppc64le tab
e75eb4e 
Conformance job is already in the conformance tab

Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adisky
To complete the pull request process, please ask for approval from sergeykanzhelev and additionally assign timothysc after the PR has been reviewed.
You can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adisky
Copy link
Contributor Author

adisky commented Nov 18, 2021

@adisky please rebase

done

This was referenced Nov 22, 2021
Closed
Closed
Rajalakshmi-Girish
Rajalakshmi-Girish suggested changes Nov 23, 2021
View reviewed changes
config/testgrids/conformance/conformance-all.yaml
@@ -322,8 +322,6 @@ test_groups:
days_of_results: 7
column_header:
- configuration_value: k8s-build-version
- name: ppc64le-unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Removal of this test group altogether shall miss the k8s unit testing on ppc64le.
Must find the appropriate place to add this test group and create a corresponding dashboard.
@mkumatag

ehashman
ehashman reviewed Nov 23, 2021
View reviewed changes
config/testgrids/kubernetes/sig-node/config.yaml
description: conformance test results for ppc64le ****This is moved under conformance dashboard, WILL BE REMOVED FROM HERE IN THE FUTURE****
- name: unit-tests
test_group_name: ppc64le-unit
description: unit test results for ppc64le
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file LGTM!

@mkumatag
Copy link
Member

Please wait till we find a new place for these jobs

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

@adisky: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@adisky
Copy link
Contributor Author

adisky commented Jan 25, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@adisky: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Member

Please wait till we find a new place for these jobs

@mkumatag who owns these jobs? They are not SIG Node's, they should not be on SIG Node's dashboards. We can move them to the appropriate SIG.

@mkumatag
Copy link
Member

Please wait till we find a new place for these jobs

@mkumatag who owns these jobs? They are not SIG Node's, they should not be on SIG Node's dashboards. We can move them to the appropriate SIG.

We have already removed from SIG node, please confirm and let us know..

@Rajalakshmi-Girish
Copy link
Contributor

Rajalakshmi-Girish commented Jan 27, 2022 •
edited
Loading

@ehashman Below PR moved them to a different dashboard:
#24672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@Rajalakshmi-Girish Rajalakshmi-Girish Rajalakshmi-Girish requested changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@karan karan Awaiting requested review from karan

Assignees

@SergeyKanzhelev SergeyKanzhelev

@Rajalakshmi-Girish Rajalakshmi-Girish

Labels
area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adisky @matthyx @ehashman @k8s-ci-robot @mkumatag @Rajalakshmi-Girish @SergeyKanzhelev