Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg-k8s-infra: auto-deploy prowjob for k8s-infra-prow #23467

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 3, 2021

Auto-deploy k8s-infra-prow if no-one is on-call.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Auto-deploy k8s-infra-prow if no-one is on-call.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2021

cc @spiffxp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2021
Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Just to show my support :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaodaiG
Copy link
Contributor

chaodaiG commented Sep 3, 2021

this will work. But recommend creating two jobs:

by adding the second one, you'll be able to easily pause bump by commenting /hold on bumping PR when something bad is going on

@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2021

this will work. But recommend creating two jobs:

* one add `skip-review` label, runs twice a day

* the other one doesn't add `skip-review` label, runs much more frequently, for example https://github.com/kubernetes/test-infra/blob/790a4398fcf59aaa77945dc568c3c1db8dc2453a/config/jobs/kubernetes/test-infra/test-infra-trusted.yaml#L877

by adding the second one, you'll be able to easily pause bump by commenting /hold on bumping PR when something bad is going on

Thank you for your input! I plan to do this as a followup once I fixed : kubernetes/k8s.io#2559.

Currently k8s-infra-prow is not operational so auto-bump is not really a big deal.

@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4841b92 into kubernetes:master Sep 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 3, 2021
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-prow.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-prow.yaml

In response to this:

Auto-deploy k8s-infra-prow if no-one is on-call.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ameukam added a commit to ameukam/test-infra that referenced this pull request Oct 8, 2021
Followup of kubernetes#23467.

Add a second prowjob that doesn't had the label `skip-review`.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam deleted the auto-bump-k8s-infra-prow branch March 7, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants