Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-k8s-infra: auto-deploy k8s-infra-prow #23961

Merged
merged 1 commit into from
Oct 9, 2021
Merged

sig-k8s-infra: auto-deploy k8s-infra-prow #23961

merged 1 commit into from
Oct 9, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 8, 2021

Followup of #23467.

Add a second prowjob that doesn't had the label skip-review.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@ameukam
sig-k8s-infra: auto-deploy k8s-infra-prow
22b6b44 
Followup of kubernetes#23467.

Add a second prowjob that doesn't had the label `skip-review`.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@ameukam
Copy link
Member Author

ameukam commented Oct 8, 2021

Suggested by chaodaiG : #23467 (comment)

cc @spiffxp

spiffxp
spiffxp approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 20f2c21 into kubernetes:master Oct 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-k8s-infra-prow.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-prow.yaml

In response to this:

Followup of #23467.

Add a second prowjob that doesn't had the label skip-review.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam deleted the prow-auto-deploy branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @spiffxp