images/bootstrap: Allow pip an external python installation #30695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow of: - kubernetes#30409 the image failed to build with: ``` Step #1: ╰─> To install Python packages system-wide, try apt install Step #1: python3-xyz, where xyz is the package you are trying to Step #1: install. Step #1: Step #1: If you wish to install a non-Debian-packaged Python package, Step #1: create a virtual environment using python3 -m venv path/to/venv. Step #1: Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make Step #1: sure you have python3-full installed. Step #1: Step #1: If you wish to install a non-Debian packaged Python application, Step #1: it may be easiest to use pipx install xyz, which will manage a Step #1: virtual environment for you. Make sure you have pipx installed. Step #1: Step #1: See /usr/share/doc/python3.11/README.venv for more information. ``` Starting with bookworm, pip enforces [PEP 668](https://peps.python.org/pep-0668/). This is an attempt to ensure we don't break python packages installation. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/images
sig/testing
|
/retest |
BenTheElder
reviewed
Sep 12, 2023
| @@ -51,7 +51,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| zip \ | |||
| zlib1g-dev \ | |||
| && rm -rf /var/lib/apt/lists/* \ | |||
| && python3 -m pip install --no-cache-dir --upgrade pip setuptools wheel | |||
| && python3 -m pip install --no-cache-dir --break-system-packages --upgrade pip setuptools wheel | |||
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-test-infra-unit-test |
|
Failed during docker installation: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-bootstrap/1701711340688642048. |
|
Switching distros requires patching this. |
ameukam
added a commit
to ameukam/test-infra
that referenced
this pull request
Sep 13, 2023
Follow-up of: - kubernetes#30695 Ensure docker installation on bookworm Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow of:
the image failed to build with:
Starting with bookworm, pip enforces PEP 668.
This is an attempt to ensure we don't break python packages installation.