Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images/bootstrap: update Docker installation #30701

Merged
merged 1 commit into from
Sep 13, 2023
Merged

images/bootstrap: update Docker installation #30701

merged 1 commit into from
Sep 13, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 13, 2023

Follow-up of:

Ensure docker installation on bookworm

@ameukam
images/bootstrap: update Docker installation
5ed9207 
Follow-up of:
  - kubernetes#30695

Ensure docker installation on bookworm

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2023
@ameukam
Copy link
Member Author

ameukam commented Sep 13, 2023

cc @BenTheElder @listx

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 13, 2023
BenTheElder
BenTheElder reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ameukam
Copy link
Member Author

ameukam commented Sep 13, 2023

/retest

@dims
Copy link
Member

dims commented Sep 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8c440c6 into kubernetes:master Sep 13, 2023
5 checks passed
@ameukam
Copy link
Member Author

ameukam commented Sep 13, 2023

image built:

$crane digest gcr.io/k8s-staging-test-infra/bootstrap:v20230913-8c440c63ea
sha256:35c763b496b0a2b1607c7812af8b7af69b637e8af6f1630f46b8426d37561cde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea Awaiting requested review from aojea

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @dims @k8s-ci-robot @BenTheElder