Split “can approve English content changes” from “can review general website changes” permissions

[sftim]

This is a Feature Request

What would you like to be added
At the time of writing, someone who is an approver for English gets approve access to the website overall, bar a few places where the top level permission is not inherited.

We should narrow this.

Why is this needed
Being good at English doesn't mean you are also good at managing OWNERS_ALIASES files, for example.

Comments
This change lets us lower the barrier for people approving for English.

[Pradumnasaraf]

/triage accepted

[a-mccarthy]

@sftim To clarify, are you suggesting that we should narrow English approver access to only the /en directory? In the same way the localization teams are granted access to only the language directory for the team they are a part of?

I think thats and interesting idea, and probably makes sense to have more fine grained ways to grant access to parts of the repo.

[sftim]

are you suggesting that we should narrow English approver access to only the /en directory? In the same way the localization teams are granted access to only the language directory for the team they are a part of?

Exactly this. We then need to have other approvers for things that aren't English (eg: CSS; images; the container image build process), which we'd assign appropriately.

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[sftim]

/triage accepted

[divya-mohan0209]

Based on your previous comment, @sftim , would it be worthwhile having the approver/reviewer list for these different areas curated like we have for blogs and for the localizations?
You mentioned a few above and I was wondering if we could achieve the same granularity that you're proposing for the general website when it comes to css, images etc.

[sftim]

Mostly I want to find what's easy for people. I don't think we've found the right point yet.

So, perhaps the split is just into three areas:

• English-only content
• common content, but not anything that lets you act like an admin
• website admins (unchanged from current list of admins)

We can add more if we think it'd help.

[sftim]

See PR #42206

[sftim]

Done in #42206

/close

[k8s-ci-robot]

@sftim: Closing this issue.

In response to this:

Done in #42206

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.