Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to finer controls on approver access #42206

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Switch to finer controls on approver access #42206

merged 3 commits into from
Apr 18, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jul 25, 2023

  • Add a new website owners group
    • Separate out “I can approve changes to English” from “I can approve changes anywhere on the website”
  • Add labels to PRs that make web development changes
  • Let the localization team review changes that add new localizations (?)
  • Don't allow English reviewers to review changes for other languages (website owners still can)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language labels Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added the language/fr Issues or PRs related to French language label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Fale July 25, 2023 13:57
@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 25, 2023
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f680c9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/660f3cb31f8dd5000826d24b
😎 Deploy Preview https://deploy-preview-42206--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Jan 7, 2024

I need to make time to work on this.

@sftim
Copy link
Contributor Author

sftim commented Apr 3, 2024

Relevant to #45762

@sftim sftim mentioned this pull request Apr 3, 2024
Closed
@sftim sftim force-pushed the 20230725_update_owners branch 2 times, most recently from 121db8e to 4e40dfa Compare April 4, 2024 23:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 4, 2024
@sftim
Copy link
Contributor Author

sftim commented Apr 4, 2024

/retitle Switch to finer controls on approver access

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Update OWNERS Switch to finer controls on approver access Apr 4, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@sftim
Copy link
Contributor Author

sftim commented Apr 4, 2024

/remove-sig release
/remove-area release-eng

@k8s-ci-robot k8s-ci-robot removed sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Apr 4, 2024
sftim
sftim commented Apr 4, 2024
View reviewed changes
OWNERS_ALIASES
Comment on lines +26 to 33
sig-docs-localization-reviewers: # PR reviews for localization changes
- a-mccarthy
- divya-mohan0209
- natalisucks
- nate-double-u
- reylejano
- sftim
- seokho-son
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new (but likely same as localization owners)

@sftim
Allow release leads to make site-level changes
7f680c9 
This is required to allow changes to the Hugo configuration.
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 4, 2024
@natalisucks
Copy link
Contributor

/lgtm
/hold

This looks good to me, however, I'd like for this change to take place after the v1.30 release (currently slated for April 17, 2024), so that no behaviour changes for the Docs Lead and Release Lead (cc. @drewhagen @katcosgrove).

Thanks for this, @sftim 🤝

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b0f7866fe69e318a0304c3002bd8506ea73b313d

sftim
sftim commented Apr 5, 2024
View reviewed changes
OWNERS_ALIASES
Comment on lines -29 to -30
- drewhagen # RT 1.30 Docs Lead
- katcosgrove # RT 1.30 Lead
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved, not removed

@reylejano
Copy link
Member

This change makes sense to me, the en owners group should only be allowed to approve en PRs while website-owners have the ability to approve other localizations

/approve

With 1.30 released yesterday (April 17, 2024), I'm unholding this PR
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit b1479aa into kubernetes:main Apr 18, 2024
6 checks passed
@sftim sftim deleted the 20230725_update_owners branch April 18, 2024 16:48
@Okabe-Junya Okabe-Junya mentioned this pull request May 17, 2024
Merged
@Okabe-Junya Okabe-Junya mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan Awaiting requested review from anubha-v-ardhan

@Fale Fale Awaiting requested review from Fale

Assignees

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @natalisucks @k8s-ci-robot @reylejano @lukaluka111L