Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add i18n/OWNERS" #10886

Merged
merged 11 commits into from
Nov 5, 2018
Merged

Revert "Add i18n/OWNERS" #10886

merged 11 commits into from
Nov 5, 2018

Conversation

chenopis
Copy link
Contributor

@chenopis chenopis commented Nov 5, 2018

Reverts #10811

This is causing build errors.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0c01318

https://deploy-preview-10886--kubernetes-io-master-staging.netlify.com

@cody-clark
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2018
@zacharysarah
Copy link
Contributor

@chenopis Let me take a look, I saw build errors as well I initially but thought I’d fixed them before merge. I’d prefer not to revert if possible and fix instead.

@k8s-ci-robot k8s-ci-robot merged commit 2a114ab into master Nov 5, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0c01318

https://deploy-preview-10886--kubernetes-io-master-staging.netlify.com

@chenopis
Copy link
Contributor Author

chenopis commented Nov 5, 2018

@zacharysarah This hosed all the PRs that came afterwards, e.g.

screen shot 2018-11-05 at 11 50 33 am

Consequently, I think it's better to revert now so as to unblock the rest of the PRs, then submit a new PR and test. That will give you more time to make sure it's working correctly.

@chenopis chenopis deleted the revert-10811-add-i18n-OWNERS branch November 5, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants