Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n/OWNERS #10811

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Add i18n/OWNERS #10811

merged 1 commit into from
Nov 2, 2018

Conversation

zacharysarah
Copy link
Contributor

This PR makes it possible for localization teams to add or change i18n/*.toml files without need for superfluous English review.

For example, @kubernetes/sig-docs-ko-owners could initialize and approve their own ko.toml file.

/cc:
@kubernetes/sig-docs-ja-owners
@kubernetes/sig-docs-ko-owners
@kubernetes/sig-docs-zh-owners

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit b6ba2c6

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bdb8242dd28ef36c6aca3ac

@zacharysarah
Copy link
Contributor Author

/assign cody-clark

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 1, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging failed.

Built with commit 589caf0

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bdb82e567610c536f08bab6

Enable reviews/approvers for localized site strings
589caf0 
Remove unintentional changes from a different branch

Correct English alias
xiangpengzhao
xiangpengzhao reviewed Nov 2, 2018
View reviewed changes
i18n/OWNERS
# This is the directory for internationalized site strings.

reviewers:
- sig-docs-pr-reviews
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this group to sig-docs-en-reviews (as its related appovers group is called sig-docs-en-owners)? It's OK as-is, but it may cause kinda confusing in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep an easily findable group for docs PRs, but I agree that because it doesn't follow convention that it's unnecessarily confusing. I'll add a separate team for EN reviews following the same naming conventions.

@cody-clark
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@cstoku cstoku mentioned this pull request Nov 2, 2018
Closed
2 tasks
@zacharysarah
Copy link
Contributor Author

@cody-clark👋 Thanks for the approval! Would you please stick an /lgtm on here as well? Thanks in advance!

@cody-clark
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 81b2562 into kubernetes:master Nov 2, 2018
@gochist gochist mentioned this pull request Nov 4, 2018
Merged
chenopis added a commit that referenced this pull request Nov 5, 2018
@chenopis
Revert "Enable reviews/approvers for localized site strings (#10811)"
0c01318 
This reverts commit 81b2562.
@chenopis chenopis mentioned this pull request Nov 5, 2018
Merged
k8s-ci-robot pushed a commit that referenced this pull request Nov 5, 2018
@chenopis @k8s-ci-robot
Revert "Add i18n/OWNERS" (#10886)
2a114ab 
* Revert "Update tutorial to work with Katacoda, No Install (#10797)"

This reverts commit a0b97a3.

* Revert "clean-up minikube toc (#10873)"

This reverts commit 18343eb.

* Revert "Tutorial cleanup: Delete K8s 101 and 201 (#10786)"

This reverts commit e0168fd.

* Revert "fix word err in Disruption (#10884)"

This reverts commit d01b76d.

* Revert "Fix typo (#10877)"

This reverts commit 1551868.

* Revert "add note informing users of env var updates (#10819)"

This reverts commit 795de19.

* Revert "Fix typo in word repositories (#10883)"

This reverts commit 6d7f27e.

* Revert "Add i18n strings for Korean translation (#10611)"

This reverts commit a9d8c54.

* Revert "Modified into appropriate words (#10768)"

This reverts commit 7ebdd66.

* Revert "Update tools.md (#10753)"

This reverts commit 2d8bc15.

* Revert "Enable reviews/approvers for localized site strings (#10811)"

This reverts commit 81b2562.
@zacharysarah zacharysarah mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao xiangpengzhao left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@cody-clark cody-clark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zacharysarah @k8sio-netlify-preview-bot @cody-clark @k8s-ci-robot @xiangpengzhao