Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add i18n/OWNERS, update aliases #10888

Closed
wants to merge 3 commits into from
Closed

[WIP] Add i18n/OWNERS, update aliases #10888

wants to merge 3 commits into from

Conversation

zacharysarah
Copy link
Contributor

Re-attempt #10811

/assign @cody-clark @chenopis

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit d27ae45

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5be0a4090ff8d40b16b2086b

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 5, 2018

Deploy preview for kubernetes-io-master-staging failed.

Built with commit d9d89a3

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5be0a606daeb0a33461d9a77

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chenopis

If they are not already assigned, you can assign the PR to them by writing /assign @chenopis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2018
@zacharysarah
Copy link
Contributor Author

zacharysarah commented Nov 5, 2018

After testing, it looks like the build failure is due specifically to the presence of an OWNERS file in i18n/, more specifically that i18n/ is a theme folder in Hugo and may have invisible and/or undocumented restrictions:

12:20:43 PM: Executing user command: hugo --enableGitInfo -b $DEPLOY_PRIME_URL
12:20:43 PM: Error: Failed to load translations in file "OWNERS": failed to unmarshal OWNERS: unsupported file extension

The top-level config.toml file specifies to ignore OWNERS files when rendering, which it does in all other cases without complaint:

ignoreFiles = [ "^OWNERS$", "README[-]+[a-z]*\\.md", "^node_modules$", "content/en/docs/doc-contributor-tools" ]

So I'm guessing that there's some kind of content enforcement for i18n/ that isn't override-able, but that restriction isn't currently documented. I've reached out on Hugo's support forums to confirm:

https://discourse.gohugo.io/t/ignorefiles-and-i18n-expected-behavior/15097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants