Rename EncryptionConfig to EncryptionConfiguration #11059

stlaz · 2018-11-18T19:25:56Z

EncryptionConfig was renamed to EncryptedConfiguration and added to
the apiserver.config.k8s.io API group in Kubernetes 1.13.

The feature was previously in alpha and was not handling versions
properly, which lead to an originally unnoticed v1 in the docs.

Related to: kubernetes/kubernetes#67383

tengqm · 2018-11-19T01:42:12Z

/lgtm

markthink

中英文需要分开提PR
目前的翻译基础分支确定为 release-1.12
现在提交的分支是 dev-1.13

@stlaz

stlaz · 2018-11-19T07:17:26Z

@markthink Sorry, I don't really speak Chinese, it's just the type that changed, which is same for all the languages.
If Google Translate is correct, you'd like me to only have the English translation changed here since Chinese is meant only for 1.12? I noticed Chinese translations were even in this (dev-1.13) branch, is that a bug, then?

Bradamant3 · 2018-11-19T13:14:46Z

Please break this PR into two: one for EN, one for ZH. We have different sets of approvers for the different language directories. Thanks!

stlaz · 2018-11-19T13:21:57Z

Sure, the other PR no.: #11080

markthink · 2018-11-20T06:24:55Z

@stlaz thanks

liggitt · 2018-11-26T22:34:40Z

can you also update the flag from --experimental-encryption-provider-config to --encryption-provider-config?

/milestone 1.13

liggitt · 2018-11-26T22:35:44Z

the text on the page that indicates "Kubernetes version 1.7.0 or later is required" should be updated

if we want to continue giving instructions for pre-1.13 versions, indicate the flag and config file differences prior to 1.13

liggitt · 2018-11-26T22:36:34Z

same comments for the KMS page (kubernetes version and --encryption-provider-config)

k8sio-netlify-preview-bot · 2018-11-27T11:09:44Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit ba39dd2

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bfd6db8ec8a89742ff3a586

stlaz · 2018-11-27T11:20:57Z

The comments should be addressed at the latest version of the patch.

I mentioned the older names only at KMS, as it's still in beta and claims to be available from 1.10. I expect this version information will get bumped once it goes stable, at which point the note could be removed as well.

liggitt · 2018-11-27T14:13:01Z

content/en/docs/tasks/administer-cluster/kms-provider.md

 3. Restart your API server.

+Note:
+If you are running on Kubernetes of version lower than 1.13, you need to use `EncryptionConfig` as the kind of the object as well as `--experimental-encryption-provider-config` as the kube-apiserver flag.


suggestion:

The alpha version of the encryption feature prior to 1.13 required a config file with kind: EncryptionConfig and apiVersion: v1, and used the --experimental-encryption-provider-config flag.

I would include the same note on the encrypt-data.md page

Thanks, that sounds much better. Modified in latest push.

EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`.

liggitt · 2018-11-27T16:21:25Z

/lgtm

tfogo · 2018-11-29T17:38:35Z

/approve

k8s-ci-robot · 2018-11-29T17:38:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tfogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tfogo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`.

* Update metadata.generation behaviour for custom resources (#10705) * update docs promoting plugins to beta (#10796) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md (#11031) * ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md * ADD content/zh/docs/reference/setup-tools/kubeadm/generated/kubeadm_init.md * Update content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md Accepted Co-Authored-By: YouthLab <tsui@highyouth.com> * do not change 'master' or 'worker' nodes to '主从' * Doc updates for volume scheduling GA (#10743) * Doc updates for volume scheduling GA * Make trivial change to kick build * Document nodelease feature (#10699) * advanced audit doc for ModeBlockingStrict (#10203) * Rename EncryptionConfig to EncryptionConfiguration (#11080) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. * content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md * trsanlate create-cluster-kubeadm.md to chinese (#11041) * trsanlate create-cluster-kubeadm.md to chinese * Update create-cluster-kubeadm.md * update the feature stage in v1.13 (#11307) * update new feature gates to document (#11295) * refresh controller role list on rbac description page (#11290) * node labeling restriction docs (#10944) * Update 1.13 docs for CSI GA (#10893) * dynamic audit documentation (#9947) * adds dynamic audit documentation * Copyedit for clarity See also inline question/s * Fix feature state shortcode * Update feature state * changes wording for dynamic audit flag behavior * Minor copyedit * fix dynamic audit yaml * adds api enablement command to dynamic audit docs * change ordering dynamic audit appears in * add references to dynamic audit in webhook backend * reword dynamic audit reference * updates stages field for audit sink object * changes audit sink api definition; rewords policy * kubeadm: remove kube-proxy workaround (#11162) * zh-trans content/en/docs/setup/independent/install-kubeadm.md (#11338) * zh-trans content/en/docs/setup/independent/install-kubeadm.md * Update install-kubeadm.md * Update dry run feature to beta (#11140) * vSphere volume raw block support doc update (#10932) * Add docs for Windows DNS configurations (#10036) * Update docs for fields allowed at root of CRD schema (#9973) * Add docs for Windows DNS configurations * add device monitoring documentation (#9945) * kubeadm: adds upgrade instructions for 1.13 (#11138) * kubeadm: adds upgrade instructions for 1.13 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * add minor copyedits Addressed a couple of copyedit comments a bit more cleanly. * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm external etcd HA upgrade 1.13 (#11364) * kubeadm external etcd HA upgrade 1.13 Signed-off-by: Ruben Orduz <rubenoz@gmail.com> * Update stacked controlplane steps * kubeadm cert documentation (#11093) * kubeadm certificate API and CSR documentation * copyedits * fix typo * PR for diff docs (#10789) * Empty commit against dev-1.13 for diff documentation * Complete Declarative maangement with diff commands * Second Korean l10n work for dev-1.13. (#11030) * Update outdated l10n(ko) contents (#10915) * Translate main menu for l10n(ko) docs (#10916) * Translate tasks/run-application/horizontal-pod-autoscale-walkthrough (#10980) * Translate content/ko/docs/concepts/overview/working-with-objects/kubernetes-object in Korean #11104 (#11332) * Pick-right-solution page translates into Korean. (#11340) * ko-trans: add jd/..., sap/..., ebay/..., homeoffice/... (#11336) * Translate concept/workloads/pods/pod-overview.md (#11092) Co-authored-by: June Yi <june.yi@samsung.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: zerobig <38598117+zer0big@users.noreply.github.com> Co-authored-by: Claudia J.Kang <claudiajkang@gmail.com> Co-authored-by: lIuDuI <1693291525@qq.com> Co-authored-by: Woojin Na(Eddie) <cheapluv@gmail.com> * Rename encryption-at-rest related objects (#11059) EncryptionConfig was renamed to EncryptedConfiguration and added to the `apiserver.config.k8s.io` API group in Kubernetes 1.13. The feature was previously in alpha and was not handling versions properly, which lead to an originally unnoticed `v1` in the docs. Also, the `--experimental-encryption-provider-config` flag is now called just `--encryption-provider-config`. * Documenting FlexVolume Resize alpha feature. (#10097) * CR webhook conversion documentation (#10986) * CR Conversion * Addressing comments * Addressing more comments * Addressing even more comments * Addressing even^2 more comments * Remove references to etcd2 in v1.13 since support has been removed (#11414) * Remove etcd2 references as etcd2 is deprecated Link back to the v1.12 version of the etcd3 doc for the etcd2->etcd3 migration instructions. I updated the kube-apiserver reference manually, unsure if that is auto-generated somehow. The federation-apiserver can still potentially support etcd2 so I didn't touch that. * Remove outdated {master,node}.yaml files There are master/node yaml files that reference etcd2.service that are likely highly out of date. I couldn't find any docs that actually reference these templates so I removed them * Address review comments * Final Korean l10n work for dev-1.13 (#11440) * Update outdated l10n(ko) contents (#11425) fixes #11424 * Remove references to etcd2 in content/ko (#11416) * Resolve conflicts against master for /ko contents (#11438) * Fix unopened caution shortcode * kubeadm: update the reference docs for 1.13 (#10960) * docs update to promote TaintBasedEvictions to beta (#10765) * First Korean l10n work for dev-1.13 (#10719) * Update outdated l10n(ko) contents (#10689) fixes #10686 * Translate concepts/overview/what-is-kubernetes in Korean (#10690) * Translate concepts/overview/what-is-kubernetes in Korean * Feedback from ClaudiaJKang * Translate concepts/overview/components in Korean (#10882) * Translate concepts/overview/components in Korean #10717 * Translate concepts/overview/components in Korean * Translate concepts/overview/components in Korean * Apply Korean glossary: 서비스 어카운트 * Translate concepts/overview/kubernetes-api in Korean (#10773) * Translate concepts/overview/kubernetes-api in Korean * Applied feedback from ianychoi * kubeadm: update the configuration docs to v1beta1 (#10959) * kubeadm: add small v1beta1 related updates (#10988) * update new feature gates to document (#11295) * Update dry run feature to beta (#11140) * kubeadm: add improvements to HA docs (#11094) * kubeadm: add information and diagrams for HA topologies * kubeadm: update HA doc with simplified steps * kubeadm: update HA doc with simplified steps * edit ha, add new topology topic, reorder by weight * troubleshoot markdown * fix more markdown, fix links * more markdown * more markdown * more markdown * changes after reviewer comments * add steps about Weave * update note about stacked topology * kubeadm: update reference docs - add section about working with phases under kubeadm-init.md - update GA / beta status of features - kubeadm alpha phase was moved to kubeadm init phase - new commands were added under kubeadm alpha - included new CoreDNS usage examples * Generate components and tools reference * Add generated federation API Reference (#11491) * Add generated federation API Reference * Add front matter to federation reference * Remove whitespace from federation front matter * Remove more whitespace from federation front matter * Remove superfluous kubefed reference * Add frontmatter to generated kubefed reference * Fix kubefed reference page frontmatter * Generate kubectl reference docs 1.13 (#11487) * Generate kubectl reference docs 1.13 * Fix links in kubectl reference * Add 1.13 API reference (#11489) * Update config.toml (#11486) * Update config.toml Preparing for 1.13 release, updating the config.toml and dropping the 1.8 docs reference. * update dot releases and docsbranch typo * adding .Site. to Params.currentUrl (#11503) see #11502 for context * Add 1.13 Release notes (#11499)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2018

k8s-ci-robot requested review from smarterclayton and tengqm November 18, 2018 19:26

k8s-ci-robot added language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language labels Nov 18, 2018

k8s-ci-robot assigned tengqm Nov 19, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2018

markthink reviewed Nov 19, 2018

View reviewed changes

stlaz force-pushed the encrypt_promote_113 branch from 1adfe7c to 2327d12 Compare November 19, 2018 13:18

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2018

idealhack removed the language/zh Issues or PRs related to Chinese language label Nov 20, 2018

stlaz force-pushed the encrypt_promote_113 branch from 2327d12 to b91a329 Compare November 27, 2018 11:09

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2018

liggitt reviewed Nov 27, 2018

View reviewed changes

stlaz force-pushed the encrypt_promote_113 branch from b91a329 to ba39dd2 Compare November 27, 2018 16:15

k8s-ci-robot assigned liggitt Nov 27, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018

Bradamant3 added this to the 1.13 milestone Nov 28, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018

k8s-ci-robot merged commit bfba863 into kubernetes:dev-1.13 Nov 29, 2018

stlaz mentioned this pull request Apr 1, 2022

REQUEST: New membership for stlaz kubernetes/org#3352

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename EncryptionConfig to EncryptionConfiguration #11059

Rename EncryptionConfig to EncryptionConfiguration #11059

stlaz commented Nov 18, 2018

tengqm commented Nov 19, 2018

markthink left a comment •

edited

Loading

stlaz commented Nov 19, 2018

Bradamant3 commented Nov 19, 2018

stlaz commented Nov 19, 2018

markthink commented Nov 20, 2018

liggitt commented Nov 26, 2018

liggitt commented Nov 26, 2018

liggitt commented Nov 26, 2018

k8sio-netlify-preview-bot commented Nov 27, 2018 •

edited

Loading

stlaz commented Nov 27, 2018

liggitt Nov 27, 2018

liggitt Nov 27, 2018

stlaz Nov 27, 2018

liggitt commented Nov 27, 2018

tfogo commented Nov 29, 2018

k8s-ci-robot commented Nov 29, 2018

Rename EncryptionConfig to EncryptionConfiguration #11059

Rename EncryptionConfig to EncryptionConfiguration #11059

Conversation

stlaz commented Nov 18, 2018

tengqm commented Nov 19, 2018

markthink left a comment • edited Loading

Choose a reason for hiding this comment

stlaz commented Nov 19, 2018

Bradamant3 commented Nov 19, 2018

stlaz commented Nov 19, 2018

markthink commented Nov 20, 2018

liggitt commented Nov 26, 2018

liggitt commented Nov 26, 2018

liggitt commented Nov 26, 2018

k8sio-netlify-preview-bot commented Nov 27, 2018 • edited Loading

stlaz commented Nov 27, 2018

liggitt Nov 27, 2018

Choose a reason for hiding this comment

liggitt Nov 27, 2018

Choose a reason for hiding this comment

stlaz Nov 27, 2018

Choose a reason for hiding this comment

liggitt commented Nov 27, 2018

tfogo commented Nov 29, 2018

k8s-ci-robot commented Nov 29, 2018

markthink left a comment •

edited

Loading

k8sio-netlify-preview-bot commented Nov 27, 2018 •

edited

Loading