Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of kube-dns in kubeadm docs #26821

Closed
wants to merge 45 commits into from
Closed

Remove mentions of kube-dns in kubeadm docs #26821

wants to merge 45 commits into from

Conversation

rajansandeep
Copy link
Contributor

Kubeadm is removing support for the deprecated kube-dns addon. This PR clears any mention of kube-dns from the kubeadm docs and also indicate that kube-dns is not supported from 1.21

Related to: kubernetes/kubeadm#1943

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2021
@rajansandeep
Copy link
Contributor Author

/cc @neolit123

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2021
@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cdec629

https://deploy-preview-26821--kubernetes-io-master-staging.netlify.app

@neolit123
Copy link
Member

@rajansandeep
as mentioned here, this should be for the dev-1.21 branch of k/website:
kubernetes/kubernetes#99646 (comment)

neolit123
neolit123 reviewed Mar 4, 2021
View reviewed changes
content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md
Please note that although the DNS server is deployed, it will not be scheduled until CNI is installed.

{{< warning >}}
kube-dns usage with kubeadm is deprecated as of v1.18 and will be removed in a future release.
kube-dns usage with kubeadm is deprecated as of v1.18 and will is removed in v1.21.
Copy link
Member

@neolit123 neolit123 Mar 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving to sig docs to say if we can outline it like that.
i think the preference was to use version tags?

@neolit123
Copy link
Member

tech review
/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a9572f7fac7576ccfd80319ccf6031fa6924c1c

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
wwgfhf and others added 14 commits March 4, 2021 11:39
@wwgfhf @rajansandeep
Update job.md
f7583a4
@lanandra @rajansandeep
Fix typo in contribute id _index.md
127778f
@gaoguangze111 @rajansandeep
Update a word translation in page of scheduler introduction
db927ce
@jailton @rajansandeep
Update Tutorial Deploy App to use the "control plane" terminology.
2ed2153 
* Update page content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html
* Update image content/en/docs/tutorials/kubernetes-basics/public/images/module_02_first_app.svg

Signed-off-by: Jailton Lopes <jailton@gmail.com>
@liggitt @rajansandeep
Clarify stability level of admission plugins
dfbbff8
@JensHeinrich @rajansandeep
Fix sentence
dba0ea8 
Add missing verb
@oke-py @rajansandeep
chore: fix an invalid location.hash
c05fd9c
@amyXia1994 @rajansandeep
Update secret.md
8fb1636 
fix minor syntax error
@Frankkkkk @rajansandeep
Update client-libraries.md : add python pykorm lib
ce1e74f
@neha-viswanathan @rajansandeep
Migrate https://kubernetes.io/docs/concepts/cluster-administration/ce…
bf99410 
…rtificates/ to tasks section
@shu-mutou @tengqm
@sftim @seokho-son @rajansandeep
Fix Source files in localization document.
7baaf55 
Fix `Source files` section in localization document, and remove {{< release-branch >}} variable
due to `release-1.20` branch does not exist.

- improve sentence
- Fix latest branch for latest version
- Add description if latest branch does not exist
- Describe about master branch
- Apply suggestions from code review
- Unify `development branch` to` localization branch`
- Remove description for switching upstream branch
- Add description for switching upstream
- Also, add description for merging to master and new release branch.

Co-authored-by: Qiming Teng <tengqim@cn.ibm.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
@hezhizhen @rajansandeep
Fix syntax error
4491aa9
@hezhizhen @rajansandeep
Rephrase the sentence
4a14972
@hezhizhen @rajansandeep
Refine the sentence
194c082
psibi and others added 12 commits March 4, 2021 11:39
@psibi @rajansandeep
docs: Update the name of the secret in the output
e98da42 
I found it confusing that the name of secret is different that the one created. Hopefully this helps.
@chrisnegus @rajansandeep
install-kubeadm:Generalize list of distributions
b6ae4a3
@davideimola @rajansandeep
Translated in italian the "Container Lifecycle Hook" chapter
7674e01
@oke-py @rajansandeep
chore: fix invalid location.hash
eda59c5
@neha-viswanathan @rajansandeep
Replace network solution with network add-on
56f4843
@caleb15 @rajansandeep
add warning about counterintuitive readiness probe
c5e4dec 
As evidenced by kubernetes/kubernetes#27114 the naming leads one to think that a liveness probe executes after a readiness probe. This is not the case.
@juampynr @rajansandeep
Fix typo (kubernetes#26781)
98f2b81 
* Fix typo

* Reword fixed typo
@MichaelWasher @rajansandeep
Update container-environment.md with fix about service environment va…
cc41d75 
…riables not being cluster-wide
@MichaelWasher @rajansandeep
Resolve Control Plane misnaming
00a0ea1
@lsq645599166 @rajansandeep
remove the duplicated alias in zh version
6caab6d
@lsq645599166 @rajansandeep
change callout from warning to caution
17bb2a9
@rajansandeep
remove mentions of kube-dns wrt kubeadm
5487262
@rajansandeep rajansandeep changed the base branch from master to dev-1.21 March 4, 2021 16:40
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 5487262

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60410dadb4c82000071ae446

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign celestehorgan after the PR has been reviewed.
You can assign the PR to them by writing /assign @celestehorgan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Mar 4, 2021
@neolit123
Copy link
Member

neolit123 commented Mar 4, 2021 •
edited
Loading

/lgtm

actually you need to rebase....
k/website is a bit tricky in this regard, so i just store the patch, delete the local branch, create a new branch on top of dev-1.21, apply the patch there.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6101f00e4d4695a74679b99da8733dc91dc1859c

@mrbobbytables
Copy link
Member

Can you please rebase this? There are quite a few commits in here

@rajansandeep
Copy link
Contributor Author

I've messed up the branch too much.
I've opened a new PR instead. #26842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@bowei bowei Awaiting requested review from bowei

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

Assignees

@neolit123 neolit123

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.