Add CDI Devices to Device Plugin API #42001

elezar · 2023-07-12T20:11:36Z

This change expands the documentation for the Device Plugin to include
the addition of support for CDI Device Names as a feature-gated feature
in the 1.28 release as part of KEP-4009.

KEP tracking issue: Add CDI devices to device plugin API enhancements#4009
Implementation PR: Add CDI devices to device plugin API kubernetes#118254

k8s-ci-robot · 2023-07-12T20:11:45Z

Welcome @elezar!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Vikash-8090-Yadav

LGTM 👍

This change expands the documentation for the Device Plugin to include the addition of support for CDI Device Names as a feature-gated feature in the 1.28 release. Signed-off-by: Evan Lezar <elezar@nvidia.com>

netlify · 2023-07-24T08:53:32Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`9efc244`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64bfa04339b55b0008dc6101

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

…/device-plugins.md Co-authored-by: Mengjiao Liu <44460091+mengjiao-liu@users.noreply.github.com>

sftim · 2023-08-05T13:36:06Z

/sig node

sftim

Thanks for the PR!

Fixups welcome (see inline feedback)

LGTM from #42001 (review)
and for docs:
/lgtm

/approve

sftim · 2023-08-05T13:34:09Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

+   device plugin defines modifications that must be made to a container's definition to provide
+   access to the device. These modifications include:
+
+   * annotations


Are these Annotations or something else?

Yes, I think this link is valid. I've updated the link in #42600

sftim · 2023-08-05T13:35:33Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

+
+   {{< note >}}
+   The processing of the fully-qualified CDI device names by the Device Manager requires
+   the `DevicePluginCDIDevices` feature gate to be enabled. This was added as an alpha feature in


We'd prefer something like

- the `DevicePluginCDIDevices` feature gate to be enabled. This was added as an alpha feature in + that the `DevicePluginCDIDevices` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) + is enabled for the kubelet and the kube-apiserver. This was added as an alpha feature in Kubernetes

Updated in #42600

k8s-ci-robot · 2023-08-05T13:37:04Z

LGTM label has been added.

Git tree hash: 505e01498056373addc2f9c419b8054718175e4f

k8s-ci-robot · 2023-08-05T13:37:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, Vikash-8090-Yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…evice-plugin-api Add CDI Devices to Device Plugin API

These changes are a follow-up to kubernetes#42001. They make minor edits to the documentation of the DevicePlugin API. Signed-off-by: Evan Lezar <elezar@nvidia.com>

k8s-ci-robot added this to the 1.28 milestone Jul 12, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2023

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023

elezar mentioned this pull request Jul 12, 2023

Add CDI devices to device plugin API kubernetes/enhancements#4009

Open

12 tasks

elezar marked this pull request as draft July 12, 2023 20:12

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2023

k8s-ci-robot requested review from divya-mohan0209 and sftim July 12, 2023 20:12

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 12, 2023

Vikash-8090-Yadav approved these changes Jul 16, 2023

View reviewed changes

Add CDI Devices to Device Plugin API

9af46c8

This change expands the documentation for the Device Plugin to include the addition of support for CDI Device Names as a feature-gated feature in the 1.28 release. Signed-off-by: Evan Lezar <elezar@nvidia.com>

elezar force-pushed the KEP-4009/add-cdi-to-device-plugin-api branch from 83efd8d to 9af46c8 Compare July 24, 2023 08:53

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2023

elezar marked this pull request as ready for review July 24, 2023 08:53

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023

k8s-ci-robot requested review from mengjiao-liu and natalisucks July 24, 2023 08:53

mengjiao-liu reviewed Jul 25, 2023

View reviewed changes

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated Show resolved Hide resolved

Update content/en/docs/concepts/extend-kubernetes/compute-storage-net…

9efc244

…/device-plugins.md Co-authored-by: Mengjiao Liu <44460091+mengjiao-liu@users.noreply.github.com>

elezar requested review from mengjiao-liu and Vikash-8090-Yadav August 2, 2023 12:55

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 5, 2023

sftim reviewed Aug 5, 2023

View reviewed changes

k8s-ci-robot assigned sftim Aug 5, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2023

k8s-ci-robot merged commit 21cfe0c into kubernetes:dev-1.28 Aug 5, 2023

Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023

Merge pull request kubernetes#42001 from elezar/KEP-4009/add-cdi-to-d…

d7180d8

…evice-plugin-api Add CDI Devices to Device Plugin API

elezar deleted the KEP-4009/add-cdi-to-device-plugin-api branch August 17, 2023 12:41

elezar mentioned this pull request Aug 17, 2023

Make minor edits to Device Plugin documentation #42600

Merged

Vikash-8090-Yadav mentioned this pull request Aug 26, 2023

REQUEST: New membership for Vikash-8090-Yadav kubernetes/org#4413

Closed

9 tasks

elezar mentioned this pull request Sep 21, 2023

REQUEST: New membership for elezar kubernetes/org#4472

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CDI Devices to Device Plugin API #42001

Add CDI Devices to Device Plugin API #42001

elezar commented Jul 12, 2023 •

edited

Loading

k8s-ci-robot commented Jul 12, 2023

Vikash-8090-Yadav left a comment

netlify bot commented Jul 24, 2023 •

edited

Loading

sftim commented Aug 5, 2023

sftim left a comment

sftim Aug 5, 2023

elezar Aug 17, 2023

sftim Aug 5, 2023

elezar Aug 17, 2023

k8s-ci-robot commented Aug 5, 2023

k8s-ci-robot commented Aug 5, 2023

Add CDI Devices to Device Plugin API #42001

Add CDI Devices to Device Plugin API #42001

Conversation

elezar commented Jul 12, 2023 • edited Loading

k8s-ci-robot commented Jul 12, 2023

Vikash-8090-Yadav left a comment

Choose a reason for hiding this comment

netlify bot commented Jul 24, 2023 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

sftim commented Aug 5, 2023

sftim left a comment

Choose a reason for hiding this comment

sftim Aug 5, 2023

Choose a reason for hiding this comment

elezar Aug 17, 2023

Choose a reason for hiding this comment

sftim Aug 5, 2023

Choose a reason for hiding this comment

elezar Aug 17, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 5, 2023

k8s-ci-robot commented Aug 5, 2023

elezar commented Jul 12, 2023 •

edited

Loading

netlify bot commented Jul 24, 2023 •

edited

Loading