Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDI Devices to Device Plugin API #42001

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add CDI Devices to Device Plugin API #42001

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af46c8
Add CDI Devices to Device Plugin API
elezar Jul 12, 2023
9efc244
Update content/en/docs/concepts/extend-kubernetes/compute-storage-net…
elezar Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,22 @@ The general workflow of a device plugin includes the following steps:
runtime configurations for accessing the allocated devices. The kubelet passes this information
to the container runtime.

An `AllocateResponse` contains zero or more `ContainerAllocateResponse` objects. In these, the
device plugin defines modifications that must be made to a container's definition to provide
access to the device. These modifications include:

* annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these Annotations or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this link is valid. I've updated the link in #42600

* device nodes
* environment variables
* mounts
* fully-qualified CDI device names

{{< note >}}
The processing of the fully-qualified CDI device names by the Device Manager requires
the `DevicePluginCDIDevices` feature gate to be enabled. This was added as an alpha feature in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd prefer something like

-   the `DevicePluginCDIDevices` feature gate to be enabled. This was added as an alpha feature in
+   that the `DevicePluginCDIDevices` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
+  is enabled for the kubelet and the kube-apiserver. This was added as an alpha feature in Kubernetes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in #42600

v1.28.
{{< note >}}
elezar marked this conversation as resolved.
Show resolved Hide resolved

### Handling kubelet restarts

A device plugin is expected to detect kubelet restarts and re-register itself with the new
Expand Down