Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 45708 — Localize pod lifecycle to Spanish #47204

Merged
merged 35 commits into from
Aug 27, 2024
Merged

Feat: 45708 — Localize pod lifecycle to Spanish #47204

merged 35 commits into from
Aug 27, 2024

Conversation

anyulled
Copy link
Contributor

Localize pod lifecycle to Spanish.

solves #45708

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from krol3 July 19, 2024 07:42
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Jul 19, 2024
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 19, 2024
dipesh-rawat
dipesh-rawat reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build preview for the PR failed (check logs here) with following errors:

8:43:11 AM: Error: error building site: assemble: "/opt/build/repo/content/es/docs/concepts/workloads/pods/pod-lifecycle.md:1:1": unterminated quoted string in shortcode parameter-argument: '
'
make: *** [Makefile:43: deploy-preview] Error 1

Provided some suggestions below that might help resolve the errors.

content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1df7431
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66cd55d86607b9000806c09a
😎 Deploy Preview https://deploy-preview-47204--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ramrodo
ramrodo suggested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyulled thanks for your contribution.

It seems the pod-lifecycle.md original content was just updated by PR #46529 two months ago, because of that, unfortunately, some paragraphs translated here are deprecated. Could you review the new changes on the main branch and update this PR based on that, please?

content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2024
ramrodo
ramrodo reviewed Jul 29, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
ramrodo
ramrodo suggested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and some missing paragraphs.

content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/pods/pod-lifecycle.md Outdated Show resolved Hide resolved
@anyulled anyulled changed the title feat: 45708 - Localize pod lifecycle to Spanish WIP - feat: 45708 - Localize pod lifecycle to Spanish Jul 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
ramrodo
ramrodo suggested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final suggestions.

Thanks, Anyul!

anyulled and others added 8 commits August 27, 2024 06:25
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
bd552c7 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
fa128d5 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
3b9bbfe 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
8bab0fa 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
93f68b7 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
a764845 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
54d07ed 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled @ramrodo
Update content/es/docs/concepts/workloads/pods/pod-lifecycle.md
1df7431 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@anyulled anyulled requested a review from ramrodo August 27, 2024 04:28
@anyulled
Copy link
Contributor Author

Some final suggestions.

Thanks, Anyul!

thank you

ramrodo
ramrodo approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd1b2bc89915c649b7baca782e12c41eb00b39a9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@ramrodo
Copy link
Member

ramrodo commented Aug 27, 2024

/cc @electrocucaracha @krol3

@k8s-ci-robot k8s-ci-robot merged commit 34ffe8c into kubernetes:main Aug 27, 2024
6 checks passed
@ramrodo ramrodo mentioned this pull request Aug 27, 2024
Closed
@anyulled anyulled deleted the feat/45708-localize-pod-lifecycle branch August 29, 2024 06:47
@anyulled
Copy link
Contributor Author

Great! /lgtm

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramrodo ramrodo ramrodo approved these changes

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@krol3 krol3 Awaiting requested review from krol3

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@ramrodo ramrodo

@krol3 krol3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anyulled @k8s-ci-robot @ramrodo @krol3 @dipesh-rawat