feat: update minio image tag; nats imagePullSecrets #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed382
reviewed
Nov 14, 2024
| {{- end }} | ||
| {{- end }} | ||
| {{- range . }} | ||
| {{- if typeIs "slice" . }} |
There was a problem hiding this comment.
What is the case of the slice so supposed to handle? You are ranging here so the . is referring to the entity in the list, something like this?
imagePullSecrets:
- ['secret1', 'secret2']
ed382
approved these changes
Nov 14, 2024
ed382
reviewed
Nov 14, 2024
| @@ -74,7 +74,7 @@ extraDeploy: [] | |||
| image: | |||
| registry: docker.io | |||
| repository: bitnami/minio | |||
| tag: 2024.10.29-debian-12-r0 | |||
| tag: 2024.11.7-debian-12-r1 | |||
There was a problem hiding this comment.
Can you update the image inventory docs after this there is a github workflow there it will push to a branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: