Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update minio image tag; nats imagePullSecrets #235

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: update minio image tag; nats imagePullSecrets #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26f380e
update minio image
ypoplavs Nov 13, 2024
131bf39
update imagepullSecrets
ypoplavs Nov 14, 2024
3241498
update nats
ypoplavs Nov 14, 2024
b88b02a
update main
ypoplavs Nov 14, 2024
dc1c30e
fix type
ypoplavs Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/testkube-enterprise/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ dependencies:
version: 16.2.1-1
- name: nats
repository: file://./charts/nats
version: 1.2.6-3
version: 1.2.6-4
- name: minio
repository: file://./charts/minio
version: 14.8.3-1
digest: sha256:c27d4665f9ac3ecca0118fc962729fac4969c9b5ccc5229612872cf1ed49b6a7
generated: "2024-11-14T10:29:49.942152141Z"
version: 14.8.3-2
digest: sha256:0c7f12a2fbf97f360116809d28887efa99abc02ec9a9de83768c1c2440e011b0
generated: "2024-11-14T18:14:16.0603+02:00"
4 changes: 2 additions & 2 deletions charts/testkube-enterprise/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ dependencies:
condition: mongodb.enabled
- name: nats
condition: testkube-api.nats.enabled
version: 1.2.6-3
version: 1.2.6-4
repository: "file://./charts/nats"
- name: minio
version: 14.8.3-1
version: 14.8.3-2
repository: file://./charts/minio
condition: minio.enabled
maintainers:
Expand Down
6 changes: 3 additions & 3 deletions charts/testkube-enterprise/charts/minio/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: oci://registry-1.docker.io/bitnamicharts
version: 2.26.0
digest: sha256:5ff7837915aef0067bd32271ee2b10c990774c16c4b6fe0a7c5eb6e53530ce08
generated: "2024-10-31T09:35:39.451559083Z"
version: 2.27.0
digest: sha256:b711ab5874abf868a0c64353a790f17771758cee6f802acb9819be004c8460af
generated: "2024-11-13T16:53:48.961412+02:00"
2 changes: 1 addition & 1 deletion charts/testkube-enterprise/charts/minio/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ maintainers:
name: minio
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/minio
version: 14.8.3-1
version: 14.8.3-2
2 changes: 1 addition & 1 deletion charts/testkube-enterprise/charts/minio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ extraDeploy: []
image:
registry: docker.io
repository: bitnami/minio
tag: 2024.10.29-debian-12-r0
tag: 2024.11.7-debian-12-r1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the image inventory docs after this there is a github workflow there it will push to a branch

digest: ""
## Specify a imagePullPolicy
## ref: https://kubernetes.io/docs/concepts/containers/images/#pre-pulled-images
Expand Down
2 changes: 1 addition & 1 deletion charts/testkube-enterprise/charts/nats/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ keywords:
- nats
- messaging
- cncf
version: 1.2.6-3
version: 1.2.6-4
home: http://github.com/nats-io/k8s
maintainers:
- email: info@nats.io
Expand Down
16 changes: 11 additions & 5 deletions charts/testkube-enterprise/charts/nats/files/nats-box/deployment/pod-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@ spec:

# service discovery uses DNS; don't need service env vars
enableServiceLinks: false

{{- with (default .Values.global.image.pullSecretNames .Values.global.imagePullSecrets) }}
imagePullSecrets:
{{- range . }}
- name: {{ . | quote }}
{{- end }}
{{- end }}
{{- range . }}
{{- if typeIs "slice" . }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the case of the slice so supposed to handle? You are ranging here so the . is referring to the entity in the list, something like this?

imagePullSecrets:
  - ['secret1', 'secret2']

- name: {{ . | quote }}
{{- else if typeIsLike "map[string]interface {}" . }}
- name: {{ .name | quote }}
{{- else }}
- {{ . | toYaml }}
{{- end }}
{{- end }}
{{- end }}

{{- with .Values.natsBox.serviceAccount }}
{{- if .enabled }}
Expand Down
18 changes: 12 additions & 6 deletions charts/testkube-enterprise/charts/nats/files/stateful-set/pod-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,19 @@ spec:

# service discovery uses DNS; don't need service env vars
enableServiceLinks: false
{{- with (default .Values.global.image.pullSecretNames .Values.global.imagePullSecrets) }}

{{- with (default .Values.global.image.pullSecretNames .Values.global.imagePullSecrets) }}
imagePullSecrets:
{{- range . }}
- name: {{ . | quote }}
{{- end }}
{{- end }}
{{- range . }}
{{- if typeIs "slice" . }}
- name: {{ . | quote }}
{{- else if typeIsLike "map[string]interface {}" . }}
- name: {{ .name | quote }}
{{- else }}
- {{ . | toYaml }}
{{- end }}
{{- end }}
{{- end }}

{{- with .Values.serviceAccount }}
{{- if .enabled }}
Expand Down
8 changes: 4 additions & 4 deletions charts/testkube-enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ minio:
# -- Common labels which will be added to all MinIO resources
commonLabels: *common_labels
# Uncomment if you want to provide different image settings
# image:
# registry: docker.io
# repository: bitnami/minio
# tag: 2023.11.20-debian-11-r0
image:
registry: docker.io
repository: bitnami/minio
tag: 2024.11.7-debian-12-r1
# digest: ""
# pullPolicy: IfNotPresent
# Uncomment if you want to provide different client image settings
Expand Down
Loading