Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roletemplates of CluseterRole for configration management #2082

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Add roletemplates of CluseterRole for configration management #2082

merged 1 commit into from
Aug 24, 2022

Conversation

zhou1203
Copy link
Member

This PR is a fixture of issue kubesphere/console#3569
Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@zhou1203
add roletemplates for configration management
99160bb 
Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2022
@zhou1203
Copy link
Member Author

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir August 22, 2022 09:41
@wansir
Copy link
Member

wansir commented Aug 23, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7b18b6b9b066f69ffe404502862aa29b5309ef2d

@zhou1203
Copy link
Member Author

/cc @pixiake

@ks-ci-bot ks-ci-bot requested a review from pixiake August 23, 2022 06:17
@pixiake
Copy link
Collaborator

pixiake commented Aug 24, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Aug 24, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@ks-ci-bot ks-ci-bot merged commit d0ef862 into kubesphere:master Aug 24, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Aug 24, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2085

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wansir wansir Awaiting requested review from wansir

@pixiake pixiake Awaiting requested review from pixiake

Assignees

@wansir wansir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhou1203 @wansir @ks-ci-bot @pixiake