Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update workflow version and refactor the config provider #130

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

wonderflow
Copy link
Contributor

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 68.28% // Head: 68.24% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (da143a0) compared to base (c4a3995).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   68.28%   68.24%   -0.05%     
==========================================
  Files          49       48       -1     
  Lines        4326     4267      -59     
==========================================
- Hits         2954     2912      -42     
+ Misses       1011     1002       -9     
+ Partials      361      353       -8     
Flag Coverage Δ
e2etests 25.23% <100.00%> (-0.30%) ⬇️
unit-test 65.19% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/generator/generator.go 68.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive changed the title Update workflow version and refactor the config provider Feat: update workflow version and refactor the config provider Feb 6, 2023
@FogDong FogDong merged commit 7135326 into kubevela:main Feb 6, 2023
@wonderflow wonderflow deleted the updateconfig branch February 6, 2023 08:43
FogDong pushed a commit to FogDong/workflow that referenced this pull request Mar 2, 2023
…ela#130)

Update workflow version and refactor the config provider

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
FogDong added a commit that referenced this pull request Mar 2, 2023
…econcile (#144)

* Feat: update workflow version and refactor the config provider (#130)

Update workflow version and refactor the config provider

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* fix rebase

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* Feat: watch event listener in controller for a faster reconcile (#131)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* fix rebase

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

---------

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Co-authored-by: Jianbo Sun <wonderflow@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants