Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.4]Feat: watch event listener in controller for a faster reconcile #144

Merged
merged 4 commits into from
Mar 2, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 2, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

wonderflow and others added 3 commits March 2, 2023 14:00
…ela#130)

Update workflow version and refactor the config provider

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
…vela#131)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 31.25% and project coverage change: +0.62 🎉

Comparison is base (13a3531) 67.34% compared to head (84f9123) 67.96%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.4     #144      +/-   ##
===============================================
+ Coverage        67.34%   67.96%   +0.62%     
===============================================
  Files               49       48       -1     
  Lines             4346     4299      -47     
===============================================
- Hits              2927     2922       -5     
+ Misses            1043     1015      -28     
+ Partials           376      362      -14     
Flag Coverage Δ
e2etests 25.06% <35.71%> (+0.76%) ⬆️
unit-test 64.89% <6.25%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/main.go 0.98% <0.00%> (-0.01%) ⬇️
pkg/features/controller_features.go 100.00% <ø> (ø)
controllers/workflowrun_controller.go 74.82% <30.76%> (+7.15%) ⬆️
pkg/generator/generator.go 68.54% <100.00%> (ø)
pkg/executor/workflow.go 81.39% <0.00%> (+1.79%) ⬆️
pkg/context/context.go 74.83% <0.00%> (+3.31%) ⬆️
api/condition/condition.go 100.00% <0.00%> (+7.79%) ⬆️
api/v1alpha1/types.go 11.11% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants