Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update golang version and dependencies #1008

Merged
merged 4 commits into from
Jul 24, 2024
Merged

deps: Update golang version and dependencies #1008

merged 4 commits into from
Jul 24, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Jul 18, 2024 •
edited
Loading

What this PR does / why we need it:
These changes are in this PR:

  • Updated golang version to 1.22.4.
  • Created golang workspace, because this is a multi-module repository.
  • Removed unused indirect dependencies in the api module.
  • Updated various dependencies.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 18, 2024
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @jcanocan

0xFelix
0xFelix reviewed Jul 18, 2024
View reviewed changes
Makefile Show resolved Hide resolved
internal/operands/metrics/resources.go Show resolved Hide resolved
@akrejcir akrejcir mentioned this pull request Jul 19, 2024
Merged
0xFelix
0xFelix reviewed Jul 19, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@jcanocan
Copy link
Contributor

Nice job @akrejcir!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
dominikholler
dominikholler reviewed Jul 23, 2024
View reviewed changes
api/go.mod Outdated Show resolved Hide resolved
@ksimon1
Copy link
Member

ksimon1 commented Jul 24, 2024 •
edited
Loading

/hold
go 1.22.5 cannot be used, because ds automation will fail

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@ksimon1
Copy link
Member

ksimon1 commented Jul 24, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
0xFelix
0xFelix reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@jcanocan
Copy link
Contributor

/lgtm

1 similar comment
@ksimon1
Copy link
Member

ksimon1 commented Jul 24, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@akrejcir
deps: Update to golang version 1.22.4
f23f901 
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir
deps: Use golang workspace for multi-module repository
1749c9c 
Golang has workspaces feature to support repositories with
multiple modules. This commit configures this repository to use it.
With this change, we only need one vendor directory

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir
deps: Remove unused dependencies in API module
2aab8ef 
These indirect dependencies are no longer used.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir
deps: Update dependencies
07b7e83 
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@kubevirt-bot kubevirt-bot merged commit e16b108 into kubevirt:main Jul 24, 2024
12 checks passed
@akrejcir akrejcir deleted the go-1.22 branch July 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikholler dominikholler dominikholler left review comments

@0xFelix 0xFelix 0xFelix left review comments

@jcanocan jcanocan Awaiting requested review from jcanocan

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@ksimon1 ksimon1

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akrejcir @jcanocan @ksimon1 @kubevirt-bot @0xFelix @dominikholler