Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update ci-builder to go 1.22.5 #1010

Merged
merged 1 commit into from
Jul 22, 2024
Merged

deps: Update ci-builder to go 1.22.5 #1010

merged 1 commit into from
Jul 22, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Jul 19, 2024 •
edited
Loading

What this PR does / why we need it:
Updated the CI builder to use golang 1.22.5.

This has to be done before any PR that needs it: #1008

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 19, 2024
@akrejcir
Copy link
Collaborator Author

/cc @0xFelix @jcanocan

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
0xFelix
0xFelix reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that go1.22.5 is out already. Is there a reason to still use go1.22.4?

@akrejcir
Copy link
Collaborator Author

Yes, downstream only uses 1.22.4.

0xFelix
0xFelix reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downstream could also have additional patches ontop of the used go1.22.4 which are missing in the public go1.22.4. I'd vote to use the latest dot release in this case.

ci-builder/Dockerfile Outdated Show resolved Hide resolved
@0xFelix 0xFelix mentioned this pull request Jul 19, 2024
Merged
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@akrejcir
deps: Update ci-builder to go 1.22.5
2d9d7a7 
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@akrejcir akrejcir changed the title deps: Update ci-builder to go 1.22.4 deps: Update ci-builder to go 1.22.5 Jul 19, 2024
0xFelix
0xFelix approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@akrejcir
Copy link
Collaborator Author

/retest

1 similar comment
@akrejcir
Copy link
Collaborator Author

/retest

@kubevirt-bot kubevirt-bot merged commit 11f5872 into kubevirt:main Jul 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@lyarwood lyarwood Awaiting requested review from lyarwood

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@0xFelix 0xFelix

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @jcanocan @kubevirt-bot @0xFelix