This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add additional host, machine and node selectors #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiratree
suggested changes
Apr 15, 2019
src/selectors/node/selectors.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| import { get } from 'lodash'; | |||
|
|
|||
| export const getNodeUnschedulable = node => get(node, 'spec.unschedulable', false); | |||
src/utils/status/host/hostStatus.js
Outdated
| @@ -18,3 +23,5 @@ export const getHostStatus = host => { | |||
| export const getSimpleHostStatus = host => getHostStatus(host).status; | |||
|
|
|||
| export const canHostAddMachine = host => [HOST_STATUS_READY].includes(getSimpleHostStatus(host)); | |||
| export const canHostStartMaintenance = hostNode => hostNode && !getNodeUnschedulable(hostNode); | |||
| export const canHostStopMaintenance = hostNode => hostNode && getNodeUnschedulable(hostNode); | |||
There was a problem hiding this comment.
no need for hostNode && in canHostStopMaintenance as getNodeUnschedulable returns false as default
src/selectors/machine/selectors.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| import { find, get } from 'lodash'; | |||
|
|
|||
| export const getMachineNode = (nodes, machine) => | |||
There was a problem hiding this comment.
can you please move this to combined.js? There is a convention for this name in other folders when the selector includes multiple entities.
src/selectors/host/selectors.js
Outdated
| export const getHostErrorMessage = host => get(host, 'status.errorMessage'); | ||
| export const getHostPoweredOn = host => _.get(host, 'status.poweredOn'); |
There was a problem hiding this comment.
isHostPoweredOn ? maybe also good to indicate default as false?
Pull Request Test Coverage Report for Build 1243
💛 - Coveralls |
atiratree
suggested changes
Apr 15, 2019
| import { getHostStatus, getSimpleHostStatus } from '../hostStatus'; | ||
| import hostFixtures from '../fixtures/hostStatus.fixture'; | ||
|
|
||
| describe('getHostStatus()', () => { |
There was a problem hiding this comment.
please remove this method or add .expected results to fixtures
flofuchs
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubevirt/web-ui#301