This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add 'Start Maintenance' action to Host #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
jtomasek
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
atiratree
reviewed
Apr 15, 2019
| @@ -56,12 +58,11 @@ const HostHeader = props => ( | |||
| const HostRow = ({ obj: host }) => { | |||
| const { | |||
| metadata: { name, namespace, uid }, | |||
There was a problem hiding this comment.
you can also use selectors for these.
| return { | ||
| hidden: !canHostStopMaintenance(node), | ||
| label: 'Stop Maintenance', | ||
| callback: () => makeNodeSchedulable(node), |
atiratree
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #274Depends on kubevirt/web-ui-components#355