Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

fix(events): style updates #360

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix(events): style updates #360

merged 1 commit into from
Apr 16, 2019

Conversation

matthewcarleton
Copy link
Contributor

@matthewcarleton matthewcarleton commented Apr 15, 2019 •
edited
Loading

updating event/font styles

@kubevirt-bot kubevirt-bot added size/S size/M needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 15, 2019
@matthewcarleton
Copy link
Contributor Author

matthewcarleton commented Apr 16, 2019 •
edited
Loading

@rawagner I've added back the text wrapper .kubevirt-health__text I saw you removed it from the last PR. I'm sure I'm not writing the React properly but it would nice to have the wrapper for the text.
I also have an issue with the build failing, but again it's due to my poor React skills :(

@rawagner
Copy link
Contributor

@matthewcarleton sorry for that, wasnt my intention, i just lost it during rebasing. I will be more careful next time :)

@matthewcarleton
Copy link
Contributor Author

@rawagner I hold nothing against you, you've saved me too many times now :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1302

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.437%
Totals Coverage Status
Change from base Build 1528: 0.0%
Covered Lines: 3439
Relevant Lines: 3770
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.437%
Totals Coverage Status
Change from base Build 1528: 0.0%
Covered Lines: 3439
Relevant Lines: 3770
💛 - Coveralls

@rawagner rawagner merged commit 0f12a76 into kubevirt:master Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewcarleton @rawagner @coveralls @kubevirt-bot