Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

fix(events): style updates #360

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix(events): style updates #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sass/components/ClusterOverview/health.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/* stylelint-disable plugin/selector-bem-pattern */
.kubevirt-dashboard__health-grid.pf-l-grid {
grid-gap: 0;
@media only screen and (min-width: 768px) {
grid-gap: 0;
}
}

.kubevirt-compliance__body {
Expand Down
3 changes: 2 additions & 1 deletion sass/components/Dashboard/consumers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@
}

.kubevirt-consumers__metric-description {
text-align: left;
padding: 0;
}

.kubevirt-consumers__metric-description,
.kubevirt-consumers__metric-type {
text-align: left;
font-size: 0.875rem;
}

.kubevirt-consumers__filters {
Expand Down
5 changes: 5 additions & 0 deletions sass/components/Dashboard/dashboard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
align-items: center;
}

.kubevirt-dashboard__heading-icon--info {
//spacer fix :(
margin-right: -10px;
}

.kubevirt-dashboard__card--top-border {
border-top: 1px solid #d1d1d1;
}
Expand Down
74 changes: 40 additions & 34 deletions sass/components/Dashboard/events.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,69 @@
/* stylelint-disable plugin/selector-bem-pattern */
.kubevirt-events__body {
display: flex;
flex-direction: column;
min-height: 150px;
max-height: 400px;
margin-top: 15px;
}

.kubevirt-events__card-body {
margin: 0 -15px;
padding: 0;
overflow-y: auto;
}
.co-sysevent__icon-box {
display: none;
}

.kubevirt-events__card-header {
margin-bottom: 0;
}
.co-sysevent-stream__timeline {
display: none;
}

.kubevirt-events__event-item {
border-bottom: 1px solid #ededed;
}
.co-m-pane__body--alt {
margin: 0;
padding: 0;
}

/* stylelint-disable plugin/selector-bem-pattern */
.kubevirt-events__body .co-sysevent__icon-box {
display: none;
.co-sysevent-stream {
padding: 0;
}

.co-sysevent {
margin: 0;
}

.co-sysevent__source,
.co-resource-item__resource-name,
.co-sysevent__message {
font-size: 0.875rem;
}

.co-sysevent__box {
border: none;
border-bottom: solid 1px #ededed;
padding: 0;
}
}

.kubevirt-events__body .co-sysevent-stream__timeline {
.kubevirt-events__timestamp i {
display: none;
}
/* stylelint-enable */

.kubevirt-events__body .co-m-pane__body--alt {
.kubevirt-events__card-body {
margin: 0;
padding: 0;
overflow-y: auto;
}

.kubevirt-events__body .co-sysevent-stream {
padding: 0;
}

.kubevirt-events__body .co-sysevent {
margin: 0;
.kubevirt-events__card-header {
margin-bottom: 0;
}

.kubevirt-events__body .co-sysevent__box {
border: none;
border-bottom: solid 1px #ededed;
.kubevirt-events__event-item {
border-bottom: 1px solid #ededed;
}

.kubevirt-events__timestamp {
display: inline-block;
}

.kubevirt-events__timestamp i {
display: none;
}

.kubevirt-events__icon--error {
color: red;
font-size: 21px;
color: #c9190b;
font-size: 1rem;
}

/* stylelint-enable */
2 changes: 1 addition & 1 deletion sass/components/Dashboard/utilization.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@
}

.kubevirt-utilization__item-narrow-title {
font-size: 0.9em;
font-size: 0.875rem;
}
6 changes: 5 additions & 1 deletion src/components/ClusterOverview/Compliance/tests/__snapshots__/Compliance.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ exports[`<Compliance /> renders correctly 1`] = `
class="fa fa-check-circle"
/>
</div>
All nodes compliant
<span
class="kubevirt-health__text"
>
All nodes compliant
</span>
</div>
</div>
`;
2 changes: 1 addition & 1 deletion src/components/ClusterOverview/Events/tests/__snapshots__/Events.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<Events /> renders correctly 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ClusterOverview/Health/HealthBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const errorIcon = (
const HealthBody = ({ data }) => (
<React.Fragment>
{data.healthy ? healtyIcon : errorIcon}
{data.message}
<span className="kubevirt-health__text">{data.message}</span>
</React.Fragment>
);

Expand Down
6 changes: 5 additions & 1 deletion src/components/ClusterOverview/Health/tests/__snapshots__/Health.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ exports[`<Health /> renders correctly 1`] = `
class="fa fa-exclamation-circle"
/>
</div>
Error message
<span
class="kubevirt-health__text"
>
Error message
</span>
</div>
</div>
`;
6 changes: 5 additions & 1 deletion src/components/ClusterOverview/Health/tests/__snapshots__/HealthBody.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ exports[`<Health /> renders correctly 1`] = `
class="fa fa-exclamation-circle"
/>
</div>
Error message
<span
class="kubevirt-health__text"
>
Error message
</span>
</div>
</div>
`;
2 changes: 1 addition & 1 deletion src/components/ClusterOverview/Inventory/tests/__snapshots__/Inventory.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<Inventory /> renders correctly 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ClusterOverview/TopConsumers/tests/__snapshots__/TopConsumers.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<TopConsumers /> renders correctly 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/ClusterOverview/tests/__snapshots__/ClusterOverview.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exports[`<ClusterOverview /> renders correctly with Provider 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down Expand Up @@ -270,7 +270,7 @@ exports[`<ClusterOverview /> renders correctly with Provider 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down Expand Up @@ -308,7 +308,7 @@ exports[`<ClusterOverview /> renders correctly with Provider 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/components/Dashboard/DashboardCard/DashboardCardTitleHelp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ const DashboardCardTitleHelp = ({ children }) => {
return (
<OverlayTrigger overlay={overlay} placement="top" trigger={['click']} rootClose>
<Button bsStyle="link">
<Icon type="fa" name="info-circle" className="kubevirt-dashboard__icon-sm" />
<Icon
type="fa"
name="info-circle"
className="kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</Button>
</OverlayTrigger>
);
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/Dashboard/DashboardCard/tests/__snapshots__/DashboardCardTitleHelp.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ exports[`<DashboardCardTitleHelp /> renders correctly 1`] = `
disabled={false}
>
<Icon
className="kubevirt-dashboard__icon-sm"
className="kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
name="info-circle"
type="fa"
/>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Dashboard/tests/__snapshots__/Dashboard.api.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,17 @@ exports[`<Dashboard /> API renders correctly 1`] = `
type="button"
>
<Icon
className="kubevirt-dashboard__icon-sm"
className="kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
name="info-circle"
type="fa"
>
<FontAwesome
className="kubevirt-dashboard__icon-sm"
className="kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
name="info-circle"
>
<span
aria-hidden={true}
className="fa fa-info-circle kubevirt-dashboard__icon-sm"
className="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</FontAwesome>
</Icon>
Expand Down
2 changes: 1 addition & 1 deletion src/components/StorageOverview/Events/tests/__snapshots__/Events.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<Events /> renders correctly 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/StorageOverview/Inventory/tests/__snapshots__/Inventory.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<Inventory /> renders correctly 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/StorageOverview/tests/__snapshots__/StorageOverview.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down Expand Up @@ -901,7 +901,7 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
>
<span
aria-hidden="true"
class="fa fa-info-circle kubevirt-dashboard__icon-sm"
class="fa fa-info-circle kubevirt-dashboard__icon-sm kubevirt-dashboard__heading-icon--info"
/>
</button>
</div>
Expand Down