This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
take storageClassConfigMap into account when creating disk patches #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
atiratree
force-pushed
the
fixAddDisk
branch
from
f735cda
to
66244c2
Compare
Pull Request Test Coverage Report for Build 2340
💛 - Coveralls |
atiratree
force-pushed
the
fixAddDisk
branch
from
66244c2
to
82b253d
Compare
|
lgtm if my comments in openshift/console#2782 get addressed. |
Signed-off-by: suomiy <suomiy@gmail.com>
atiratree
force-pushed
the
fixAddDisk
branch
from
82b253d
to
ed6fcdd
Compare
mareklibra
approved these changes
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: https://bugzilla.redhat.com/show_bug.cgi?id=1753688