Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt: take storageClassConfigMap into account when creating disks #2782

Merged
merged 1 commit into from
Oct 7, 2019
Merged

kubevirt: take storageClassConfigMap into account when creating disks #2782

merged 1 commit into from
Oct 7, 2019

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Sep 19, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2019
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2019
@atiratree
Copy link
Member Author

@mareklibra

mareklibra
mareklibra suggested changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reuse existing code, otherwise lgtm

.../packages/kubevirt-plugin/src/k8s/requests/config-map/storage-class/storageClassConfigMap.ts Outdated
@@ -0,0 +1,44 @@
import { ConfigMapModel } from '@console/internal/models';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a repeating story - I would not copy&paste the code from web-ui-components here without removing it there.

I would migrate web-ui-components to openshift/console at once - ideally in 4.3 if we get time for it.
Otherwise we will need to maintain the almost same code twice - with just tiny, hard to spot, differences on both sides. which will cause extra effort and regressions.

Copy link
Member Author

@atiratree atiratree Sep 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving it whole cannot be done easily - it should be done by parts and there will always be duplicate code until everything is ported (because of the not so straightforward dependencies)

removed for now, but still this will appear in the next patch for 4.3

@mareklibra mareklibra mentioned this pull request Sep 20, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2019
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2019
@mareklibra
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@mareklibra
Copy link
Contributor

The kubevirt/web-ui-components#555 is merged as well now.
I think there is no rush in releasing web-ui-components just for this fix atm, we can do it together with additional changes in the short term. Changes here should not break builds/tests even without kubevirt/web-ui-components#555 applied.

If you think otherwise, please let me know. I would release immediately.

@atiratree
Copy link
Member Author

@mareklibra actually we need the release because getStorageClassConfigMap is not exported in the current version.

@mareklibra
Copy link
Contributor

ok, I missed that. I will release web-ui-components.

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@mareklibra
Copy link
Contributor

Depends on: #2913

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2019
@atiratree
Copy link
Member Author

/retest

2 similar comments
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/retest

@mareklibra
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 46e08ea into openshift:master Oct 7, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra mareklibra requested changes

@pcbailey pcbailey Awaiting requested review from pcbailey

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@mareklibra mareklibra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@atiratree @mareklibra @openshift-ci-robot @spadgett @openshift-merge-robot @suomiy