This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add Role cell to hosts listing #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiratree
suggested changes
Apr 9, 2019
kubevirt-bot
added
needs-rebase
jtomasek
commented
Apr 12, 2019
| @@ -55,7 +62,21 @@ const HostRow = ({ obj: host }) => { | |||
| }, | |||
| } = host; | |||
|
|
|||
| const machineName = _.get(host, 'status.machineRef.name'); | |||
| const machineName = _.get(host, 'spec.machineRef.name'); | |||
There was a problem hiding this comment.
I'll replace this with a selector call once kubevirt/web-ui-components#333 merges
rawagner
reviewed
Apr 12, 2019
| @@ -55,7 +62,21 @@ const HostRow = ({ obj: host }) => { | |||
| }, | |||
| } = host; | |||
|
|
|||
| const machineName = _.get(host, 'status.machineRef.name'); | |||
| const machineName = getHostMachineName(host); | |||
| const machineResource = { | |||
There was a problem hiding this comment.
you can use getResource from web-ui-components which has a lot of these fields prefilled
There was a problem hiding this comment.
yeah, I tried but problem is that getResource only outputs resource kind as Model.kind and this does not work for machines as machines are stored in redux store by key which is a result of referenceForModel(MachineModel). So I had to specify the machineResource explicitly here.
I think the general goal is to keep all resources keyed using regerenceForModel in redux, so we'll have to update getResource function to handle it.
atiratree
approved these changes
Apr 12, 2019
kubevirt-bot
added
needs-rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.