Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Map for compiler memory cache #1574

Closed
wants to merge 5 commits into from
Closed

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 29, 2020

Summary

Maps are about twice as fast for larger data sets in Chrome 80, very much likely this applies to Node as well: https://stackoverflow.com/a/55711780/1850276

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

…g` (#1562)

BREAKING CHANGE:

Any custom typing files or files which are needed to be compiled and intended to use with `jest` need to be defined in `files` option of `tsconfig`.

For example
```
// tsconfig.json
{
   // ...other configs
   "files": [
       "my-custom-typings.d.ts".
       "my-global-module.ts"
   ]
}
```
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 29, 2020 08:33
@ahnpnl ahnpnl closed this Apr 29, 2020
@ahnpnl ahnpnl deleted the use-map-for-cache branch April 29, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant