docs(routing): make the examples work for marketplace demos #1717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in the blogpost / httproute / tcproute look like they should work with the marketplace demo but they actually don't (
kuma.io/service
is the same, but version tags and prefix is wrong).This combined with the "catch all" route causes an invalid MeshHTTPRoute to "sort of work" without any warning and can cause confusion down the line.
E.g. if we take the old MeshHTTPRoute with a 90/10 split:
this produces the following envoy configuration:
the first two matches will not match (not matching version/path) and the "catch all" will make the requests work with 50/50 split.
I think this is a bug in "catch all" mechanism. I think we should add the "prefix" to existing split not create a new "catch all" route. So if there is no match you get a 404 and you immediately know that there is something wrong with
MeshHTTPRoute
and not silently ignore the not working policy. WDYT? @bartsmykla (original author of kumahq/kuma#6993) @lobkovilya ( kumahq/kuma#6758 ) and @michaelbeaumont ( this docs ) also @lahabana.Kuma issue: kumahq/kuma#9885
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes