Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MeshHTTPRoute): default catch all path in route match #6993

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Jun 12, 2023

According to Envoy docs, match must have precisely one of prefix, path, safe_regex, connect_matcher, path_separated_prefix, path_match_policy set, so when policy doesn't specify explicit type of matching, we are assuming "catch all" path (any path starting with "/").

Closes: #6758

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Updated golden files for unit tests
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy?
    • There is no need
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: fix(MeshHTTPRoute): assume default catch all path (any path starting with "/") in route match when not explicitly set

According to Envoy docs, match must have precisely one of prefix,
path, safe_regex, connect_matcher, path_separated_prefix,
path_match_policy set, so when policy doesn't specify explicit type
of matching, we are assuming "catch all" path (any path starting
with "/").

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested review from michaelbeaumont, a team and jakubdyszkiewicz and removed request for a team June 12, 2023 10:02
This reverts commit 56fe057.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
This reverts commit 0f05087.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla enabled auto-merge (squash) June 12, 2023 13:31
@bartsmykla bartsmykla merged commit ffedfa2 into kumahq:master Jun 12, 2023
@bartsmykla bartsmykla deleted the chore/add-default-path-to-meshhttproute-match-when-empty branch June 12, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshHTTPRoute configuration fails in Envoy
3 participants