-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(MeshHTTPRoute): default catch all path in route match #6993
Merged
bartsmykla
merged 7 commits into
kumahq:master
from
bartsmykla:chore/add-default-path-to-meshhttproute-match-when-empty
Jun 12, 2023
Merged
chore(MeshHTTPRoute): default catch all path in route match #6993
bartsmykla
merged 7 commits into
kumahq:master
from
bartsmykla:chore/add-default-path-to-meshhttproute-match-when-empty
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Envoy docs, match must have precisely one of prefix, path, safe_regex, connect_matcher, path_separated_prefix, path_match_policy set, so when policy doesn't specify explicit type of matching, we are assuming "catch all" path (any path starting with "/"). Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
requested review from
michaelbeaumont,
a team and
jakubdyszkiewicz
and removed request for
a team
June 12, 2023 10:02
This reverts commit 56fe057. Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/listeners.go
Outdated
Show resolved
Hide resolved
...ugins/policies/meshtimeout/plugin/testdata/no-route-level-timeouts.gateway.route.golden.yaml
Outdated
Show resolved
Hide resolved
This reverts commit 0f05087. Signed-off-by: Bart Smykla <bartek@smykla.com>
…t-path-to-meshhttproute-match-when-empty
Signed-off-by: Bart Smykla <bartek@smykla.com>
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/listeners.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
michaelbeaumont
approved these changes
Jun 12, 2023
bartsmykla
deleted the
chore/add-default-path-to-meshhttproute-match-when-empty
branch
June 12, 2023 13:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Envoy docs, match must have precisely one of prefix, path, safe_regex, connect_matcher, path_separated_prefix, path_match_policy set, so when policy doesn't specify explicit type of matching, we are assuming "catch all" path (any path starting with "/").
Closes: #6758
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSUPGRADE.md
?> Changelog:
entry here or add aci/
label to run fewer/more tests?