Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install observability has namespace definition multiple times #4410

Closed
lahabana opened this issue Jun 1, 2022 · 0 comments · Fixed by #4411
Closed

install observability has namespace definition multiple times #4410

lahabana opened this issue Jun 1, 2022 · 0 comments · Fixed by #4411
Assignees
@lahabana
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Jun 1, 2022

What happened?

Only the first one has the sidecar injection so it's basically broken
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it kind/bug A bug labels Jun 1, 2022
@lahabana lahabana self-assigned this Jun 1, 2022
lahabana added a commit to lahabana/kuma that referenced this issue Jun 1, 2022
@lahabana
fix(kumactl): define namespace only once in install obs
616cdeb 
This was causing problems as prometheus doesn't get the sidecar

fix kumahq#4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Jun 1, 2022
Merged
lahabana added a commit that referenced this issue Jun 2, 2022
@lahabana
fix(kumactl): define namespace only once in install obs (#4411)
92c8b0c 
This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
mergify bot pushed a commit that referenced this issue Jun 2, 2022
@lahabana @mergify
fix(kumactl): define namespace only once in install obs (#4411)
25d89b6 
This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 92c8b0c)
lahabana added a commit that referenced this issue Jun 2, 2022
@mergify @lahabana
fix(kumactl): define namespace only once in install obs (backport #4411…
d675a90 
…) (#4418)

fix(kumactl): define namespace only once in install obs (#4411)

This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 92c8b0c)

Co-authored-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kumactl): define namespace only once in install obs lahabana/kuma
1 participant
@lahabana