-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kumactl): define namespace only once in install obs #4411
Conversation
This was causing problems as prometheus doesn't get the sidecar fix kumahq#4410 Signed-off-by: Charly Molter <charly.molter@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #4411 +/- ##
==========================================
+ Coverage 55.48% 55.53% +0.04%
==========================================
Files 941 941
Lines 57657 57657
==========================================
+ Hits 31993 32020 +27
+ Misses 23104 23094 -10
+ Partials 2560 2543 -17
Continue to review full report at Codecov.
|
/golden_files |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was causing problems as prometheus doesn't get the sidecar
fix #4410
Signed-off-by: Charly Molter charly.molter@konghq.com