Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl): define namespace only once in install obs #4411

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jun 1, 2022

This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter charly.molter@konghq.com

This was causing problems as prometheus doesn't get the sidecar

fix kumahq#4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner June 1, 2022 13:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #4411 (9f32e53) into master (7fa69fe) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4411      +/-   ##
==========================================
+ Coverage   55.48%   55.53%   +0.04%     
==========================================
  Files         941      941              
  Lines       57657    57657              
==========================================
+ Hits        31993    32020      +27     
+ Misses      23104    23094      -10     
+ Partials     2560     2543      -17     
Impacted Files Coverage Δ
pkg/plugins/common/postgres/listener.go 53.84% <0.00%> (-15.39%) ⬇️
pkg/plugins/resources/postgres/events/listener.go 16.66% <0.00%> (-14.59%) ⬇️
pkg/kds/client/sink.go 59.45% <0.00%> (-8.11%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/plugins/resources/postgres/store.go 76.79% <0.00%> (+2.10%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 100.00% <0.00%> (+2.12%) ⬆️
pkg/defaults/components.go 85.71% <0.00%> (+3.57%) ⬆️
...s/authn/api-server/tokens/admin_token_bootstrap.go 86.00% <0.00%> (+4.00%) ⬆️
pkg/core/tokens/signing_key_manager.go 90.00% <0.00%> (+5.00%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa69fe...9f32e53. Read the comment docs.

@bartsmykla
Copy link
Contributor

/golden_files

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahabana lahabana merged commit 92c8b0c into kumahq:master Jun 2, 2022
mergify bot pushed a commit that referenced this pull request Jun 2, 2022
This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 92c8b0c)
lahabana added a commit that referenced this pull request Jun 2, 2022
…) (#4418)

fix(kumactl): define namespace only once in install obs (#4411)

This was causing problems as prometheus doesn't get the sidecar

fix #4410

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 92c8b0c)

Co-authored-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana deleted the fixInstall branch March 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install observability has namespace definition multiple times
3 participants