Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to have TLS on MADS #5171

Closed
lahabana opened this issue Oct 18, 2022 · 0 comments · Fixed by #5210
Closed

Add ability to have TLS on MADS #5171

lahabana opened this issue Oct 18, 2022 · 0 comments · Fixed by #5210
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

What happened?

Useful for securing MADS
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 18, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/feature New feature and removed triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 24, 2022
lahabana added a commit to lahabana/kuma that referenced this issue Oct 25, 2022
@lahabana
feat(mads): add possibility to run MADS on TLS
18e4982 
Add configuration to be able to setup MADS port with TLS.
The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS
is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_MONITORING_ASSIGNMENT_SERVER_TLS_ENABLED=true

Fix kumahq#5171

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit to lahabana/kuma that referenced this issue Oct 25, 2022
@lahabana
feat(mads): add possibility to run MADS on TLS
1fff173 
Add configuration to be able to setup MADS port with TLS.
The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS
is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_MONITORING_ASSIGNMENT_SERVER_TLS_ENABLED=true

Fix kumahq#5171

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Oct 25, 2022
Merged
12 tasks
lahabana added a commit that referenced this issue Oct 25, 2022
@lahabana
feat(mads): add possibility to run MADS on TLS (#5210)
9fa1516 
Add configuration to be able to setup MADS port with TLS.
The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS
is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_MONITORING_ASSIGNMENT_SERVER_TLS_ENABLED=true

Fix #5171

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mads): add possibility to run MADS on TLS lahabana/kuma
2 participants
@lahabana @jakubdyszkiewicz