Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mads): add possibility to run MADS on TLS #5210

Merged
merged 2 commits into from
Oct 25, 2022
Merged

feat(mads): add possibility to run MADS on TLS #5210

merged 2 commits into from
Oct 25, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 25, 2022 •
edited by lukidzi
Loading

Add configuration to be able to setup MADS port with TLS. The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_MONITORING_ASSIGNMENT_SERVER_TLS_ENABLED=true

Fix #5171

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue -- add docs for MADS TLS kuma-website#1055
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(kuma-cp): add possibility to run MADS on TLS

@lahabana
feat(mads): add possibility to run MADS on TLS
1fff173 
Add configuration to be able to setup MADS port with TLS.
The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS
is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_MONITORING_ASSIGNMENT_SERVER_TLS_ENABLED=true

Fix kumahq#5171

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner October 25, 2022 09:37
@lahabana lahabana enabled auto-merge (squash) October 25, 2022 09:37
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but please remember about docs https://kuma.io/docs/1.8.x/security/certificates/

@lahabana lahabana merged commit 9fa1516 into kumahq:master Oct 25, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@lahabana lahabana deleted the fix5171 branch March 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to have TLS on MADS
2 participants
@lahabana @jakubdyszkiewicz