Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add new datasource to kumactl install metrics #2640

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Aug 23, 2021

Summary

This adds the plugin to grafana and add a new panel in the mesh dashboard

Full changelog

  • Update grafana to 8.1.2
  • Download the plugin in an init container and set it up as a new datasource
  • Add a panel in the new dashboard

Testing

  • Unit tests
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

This adds the plugin to grafana and add a new panel in the mesh dashboard

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana marked this pull request as ready for review August 24, 2021 08:33
@lahabana lahabana requested a review from a team as a code owner August 24, 2021 08:33
@lahabana lahabana requested a review from bartsmykla August 24, 2021 08:35
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahabana
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Command update: success

Branch has been successfully updated

@codecov-commenter
Copy link

Codecov Report

Merging #2640 (5d32a44) into master (3665e51) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2640      +/-   ##
==========================================
+ Coverage   51.97%   52.00%   +0.03%     
==========================================
  Files         871      871              
  Lines       49512    49513       +1     
==========================================
+ Hits        25733    25750      +17     
+ Misses      21699    21682      -17     
- Partials     2080     2081       +1     
Impacted Files Coverage Δ
...ctl/cmd/install/context/install_metrics_context.go 100.00% <100.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/kds/client/sink.go 52.27% <0.00%> (+4.54%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3665e51...5d32a44. Read the comment docs.

@lahabana lahabana merged commit 8e7bc99 into kumahq:master Aug 24, 2021
@lahabana lahabana deleted the feat/serviceMap branch March 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants