-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): add GatewayClass.Spec.ParametersRef
support
#4157
Merged
michaelbeaumont
merged 8 commits into
kumahq:master
from
michaelbeaumont:feat/gateway_class_parameters
Apr 14, 2022
Merged
feat(gateway): add GatewayClass.Spec.ParametersRef
support
#4157
michaelbeaumont
merged 8 commits into
kumahq:master
from
michaelbeaumont:feat/gateway_class_parameters
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
3 times, most recently
from
April 11, 2022 13:07
046f40f
to
78cee50
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…ayInstance Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
from
April 11, 2022 13:29
78cee50
to
cbc211c
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
from
April 11, 2022 13:52
a2f068a
to
f96a8bc
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
from
April 11, 2022 14:41
f96a8bc
to
463c696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
Show resolved
Hide resolved
app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
Show resolved
Hide resolved
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
from
April 14, 2022 09:48
a08225b
to
2f0fdd9
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/gateway_class_parameters
branch
from
April 14, 2022 10:00
2f0fdd9
to
aaa618f
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
jakubdyszkiewicz
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The idea here is to allow the user to specify everything about the created
MeshGatewayInstance
.GatewayClass
andGateway
whenMeshGatewayConfig
changesCloses #4146