Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): add GatewayClass.Spec.ParametersRef support #4157

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Apr 11, 2022

Summary

The idea here is to allow the user to specify everything about the created MeshGatewayInstance.

  • reconcile GatewayClass and Gateway when MeshGatewayConfig changes

Closes #4146

@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch 3 times, most recently from 046f40f to 78cee50 Compare April 11, 2022 13:07
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…ayInstance

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch from 78cee50 to cbc211c Compare April 11, 2022 13:29
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch from a2f068a to f96a8bc Compare April 11, 2022 13:52
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch from f96a8bc to 463c696 Compare April 11, 2022 14:41
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 11, 2022 19:58
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner April 11, 2022 19:58
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch from a08225b to 2f0fdd9 Compare April 14, 2022 09:48
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_class_parameters branch from 2f0fdd9 to aaa618f Compare April 14, 2022 10:00
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) April 14, 2022 15:15
@michaelbeaumont michaelbeaumont merged commit 0cd6c8f into kumahq:master Apr 14, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_class_parameters branch April 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Gateway configuration via parametersRef on GatewayClass
2 participants