Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): add GatewayClass.Spec.ParametersRef support #4157

Merged
merged 8 commits into from
Apr 14, 2022
Merged

feat(gateway): add GatewayClass.Spec.ParametersRef support #4157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d240dbb
feat(gateway): add MeshGatewayConfig resource
michaelbeaumont Apr 11, 2022
b704e07
feat(gateway): use parameters on GatewayClass when creating MeshGatew…
michaelbeaumont Apr 11, 2022
e6e9311
feat(gateway): reconcile Gateways when GatewayClasses change
michaelbeaumont Apr 11, 2022
be2f5df
feat(gatewayapi): validate GatewayClass.Spec.ParametersRef
michaelbeaumont Apr 11, 2022
4d6fbac
test(kumactl): add new resource to golden files
michaelbeaumont Apr 11, 2022
463c696
test(gateway): add test with GatewayClass.Spec.ParametersRef
michaelbeaumont Apr 11, 2022
aaa618f
feat(gateway): reconcile Gateways if MeshGatewayConfig changes
michaelbeaumont Apr 11, 2022
8718e48
docs(gateway): add more docs to MeshGatewayConfig CRDs
michaelbeaumont Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 145 additions & 35 deletions app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,55 @@ status:
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: ratelimits.kuma.io
spec:
group: kuma.io
names:
kind: RateLimit
listKind: RateLimitList
plural: ratelimits
singular: ratelimit
scope: Cluster
versions:
- name: v1alpha1
schema:
openAPIV3Schema:
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
type: string
mesh:
description: Mesh is the name of the Kuma mesh this resource belongs to.
It may be omitted for cluster-scoped resources.
type: string
metadata:
type: object
spec:
description: Spec is the specification of the Kuma RateLimit resource.
x-kubernetes-preserve-unknown-fields: true
type: object
served: true
storage: true
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
jakubdyszkiewicz marked this conversation as resolved.
Show resolved Hide resolved
michaelbeaumont marked this conversation as resolved.
Show resolved Hide resolved
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
Expand Down Expand Up @@ -611,14 +660,14 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: zoneegressinsights.kuma.io
name: dataplanes.kuma.io
spec:
group: kuma.io
names:
kind: ZoneEgressInsight
listKind: ZoneEgressInsightList
plural: zoneegressinsights
singular: zoneegressinsight
kind: Dataplane
listKind: DataplaneList
plural: dataplanes
singular: dataplane
scope: Namespaced
versions:
- name: v1alpha1
Expand All @@ -642,7 +691,7 @@ spec:
metadata:
type: object
spec:
description: Spec is the specification of the Kuma ZoneEgressInsight resource.
description: Spec is the specification of the Kuma Dataplane resource.
x-kubernetes-preserve-unknown-fields: true
type: object
served: true
Expand All @@ -660,14 +709,14 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: dataplanes.kuma.io
name: zoneegressinsights.kuma.io
spec:
group: kuma.io
names:
kind: Dataplane
listKind: DataplaneList
plural: dataplanes
singular: dataplane
kind: ZoneEgressInsight
listKind: ZoneEgressInsightList
plural: zoneegressinsights
singular: zoneegressinsight
scope: Namespaced
versions:
- name: v1alpha1
Expand All @@ -691,7 +740,7 @@ spec:
metadata:
type: object
spec:
description: Spec is the specification of the Kuma Dataplane resource.
description: Spec is the specification of the Kuma ZoneEgressInsight resource.
x-kubernetes-preserve-unknown-fields: true
type: object
served: true
Expand Down Expand Up @@ -1102,19 +1151,21 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: meshinsights.kuma.io
name: meshgatewayconfigs.kuma.io
spec:
group: kuma.io
names:
kind: MeshInsight
listKind: MeshInsightList
plural: meshinsights
singular: meshinsight
kind: MeshGatewayConfig
listKind: MeshGatewayConfigList
plural: meshgatewayconfigs
singular: meshgatewayconfig
scope: Cluster
versions:
- name: v1alpha1
schema:
openAPIV3Schema:
description: MeshGatewayConfig holds the configuration of a MeshGateway. A
GatewayClass can refer to a MeshGatewayConfig via parametersRef.
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
Expand All @@ -1126,18 +1177,77 @@ spec:
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
type: string
mesh:
description: Mesh is the name of the Kuma mesh this resource belongs to.
It may be omitted for cluster-scoped resources.
type: string
metadata:
type: object
spec:
description: Spec is the specification of the Kuma MeshInsight resource.
x-kubernetes-preserve-unknown-fields: true
description: MeshGatewayConfigSpec specifies the options available for
a Kuma MeshGateway.
properties:
replicas:
default: 1
description: Replicas is the number of dataplane proxy replicas to
create. For now this is a fixed number, but in the future it could
be automatically scaled based on metrics.
format: int32
minimum: 1
type: integer
resources:
description: Resources specifies the compute resources for the proxy
container. The default can be set in the control plane config.
properties:
limits:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Limits describes the maximum amount of compute resources
allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
requests:
additionalProperties:
anyOf:
- type: integer
- type: string
pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
x-kubernetes-int-or-string: true
description: 'Requests describes the minimum amount of compute
resources required. If Requests is omitted for a container,
it defaults to Limits if that is explicitly specified, otherwise
to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
type: object
type: object
serviceType:
default: LoadBalancer
description: ServiceType specifies the type of managed Service that
will be created to expose the dataplane proxies to traffic from
outside the cluster. The ports to expose will be taken from the
matching Gateway resource. If there is no matching Gateway, the
managed Service will be deleted.
enum:
- LoadBalancer
- ClusterIP
- NodePort
type: string
tags:
additionalProperties:
type: string
description: Tags specifies a set of Kuma tags that are included in
the MeshGatewayInstance and thus propagated to every Dataplane generated
to serve the MeshGateway. These tags should include a maximum of
one `kuma.io/service` tag.
type: object
type: object
status:
description: MeshGatewayConfigStatus holds information about the status
of the gateway instance.
type: object
type: object
served: true
storage: true
subresources:
status: {}
status:
acceptedNames:
kind: ""
Expand All @@ -1151,14 +1261,14 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: proxytemplates.kuma.io
name: meshinsights.kuma.io
spec:
group: kuma.io
names:
kind: ProxyTemplate
listKind: ProxyTemplateList
plural: proxytemplates
singular: proxytemplate
kind: MeshInsight
listKind: MeshInsightList
plural: meshinsights
singular: meshinsight
scope: Cluster
versions:
- name: v1alpha1
Expand All @@ -1182,7 +1292,7 @@ spec:
metadata:
type: object
spec:
description: Spec is the specification of the Kuma ProxyTemplate resource.
description: Spec is the specification of the Kuma MeshInsight resource.
x-kubernetes-preserve-unknown-fields: true
type: object
served: true
Expand All @@ -1200,14 +1310,14 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.8.0
creationTimestamp: null
name: ratelimits.kuma.io
name: proxytemplates.kuma.io
spec:
group: kuma.io
names:
kind: RateLimit
listKind: RateLimitList
plural: ratelimits
singular: ratelimit
kind: ProxyTemplate
listKind: ProxyTemplateList
plural: proxytemplates
singular: proxytemplate
scope: Cluster
versions:
- name: v1alpha1
Expand All @@ -1231,7 +1341,7 @@ spec:
metadata:
type: object
spec:
description: Spec is the specification of the Kuma RateLimit resource.
description: Spec is the specification of the Kuma ProxyTemplate resource.
x-kubernetes-preserve-unknown-fields: true
type: object
served: true
Expand Down
Loading