Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): unified installation of metrics/logging/tracing into one command observability #4308

Merged
merged 10 commits into from
May 23, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 18, 2022

Summary

Unified installation of metrics/logging/tracing into one command observability.

Full changelog

  • [unified installation ofmetrics/logging/tracing into one command observability. ]
  • [upgraded version of prometheus/jaeger/grafana/loki/zipkin]
  • [removed node-exporter and alert]

Issues resolved

Fix #4096

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

lukidzi added 4 commits May 18, 2022 07:55
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review May 18, 2022 16:46
@lukidzi lukidzi requested a review from a team as a code owner May 18, 2022 16:46
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. It'd be nice in a follow up PR to be able to run this stack from outside the mesh as it's the recommended way

app/kumactl/cmd/install/install_observability.go Outdated Show resolved Hide resolved
app/kumactl/cmd/install/install_tracing.go Show resolved Hide resolved
app/kumactl/cmd/install/install_observability.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #4308 (7618c00) into master (bb4e42b) will decrease coverage by 0.03%.
The diff coverage is 67.11%.

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
- Coverage   55.75%   55.71%   -0.04%     
==========================================
  Files         935      934       -1     
  Lines       56434    56444      +10     
==========================================
- Hits        31462    31450      -12     
- Misses      22498    22511      +13     
- Partials     2474     2483       +9     
Impacted Files Coverage Δ
app/kumactl/pkg/cmd/root_context.go 59.31% <ø> (ø)
test/framework/config.go 29.78% <ø> (ø)
test/framework/deployments/tracing/kubernetes.go 0.00% <0.00%> (ø)
test/framework/kumactl.go 0.00% <0.00%> (ø)
app/kumactl/cmd/install/install_logging.go 66.66% <50.00%> (ø)
app/kumactl/cmd/install/install_metrics.go 66.66% <50.00%> (-9.65%) ⬇️
app/kumactl/cmd/install/install_tracing.go 66.66% <50.00%> (ø)
app/kumactl/cmd/install/install_observability.go 69.49% <69.49%> (ø)
...d/install/context/install_observability_context.go 100.00% <100.00%> (ø)
app/kumactl/cmd/install/install.go 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4e42b...7618c00. Read the comment docs.

lukidzi added 2 commits May 19, 2022 07:22
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
lukidzi added 3 commits May 19, 2022 13:11
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
mk/kind.mk Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge kuma install metrics/tracing/logging into kuma install observability
5 participants