-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): unified installation of metrics/logging/tracing
into one command observability
#4308
Conversation
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. It'd be nice in a follow up PR to be able to run this stack from outside the mesh as it's the recommended way
app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 55.75% 55.71% -0.04%
==========================================
Files 935 934 -1
Lines 56434 56444 +10
==========================================
- Hits 31462 31450 -12
- Misses 22498 22511 +13
- Partials 2474 2483 +9
Continue to review full report at Codecov.
|
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
app/kumactl/cmd/install/context/install_observability_context.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Summary
Unified installation of
metrics/logging/tracing
into one commandobservability
.Full changelog
metrics/logging/tracing
into one commandobservability
. ]Issues resolved
Fix #4096
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy